Skip to content

[Fix] Rename LOGO_IMAGE to LogoImage to resolve react-doctor/jsx-pascal-case warning#10478

Open
NethmikaKekuu wants to merge 2 commits into
wso2:masterfrom
NethmikaKekuu:fix/jsx-pascal-case
Open

[Fix] Rename LOGO_IMAGE to LogoImage to resolve react-doctor/jsx-pascal-case warning#10478
NethmikaKekuu wants to merge 2 commits into
wso2:masterfrom
NethmikaKekuu:fix/jsx-pascal-case

Conversation

@NethmikaKekuu

Copy link
Copy Markdown

Purpose

Fixes react-doctor/jsx-pascal-case architecture warning by renaming the
LOGO_IMAGE component to LogoImage in the header component.

JSX component names must be in PascalCase so React can distinguish them from
native HTML elements. LOGO_IMAGE (SCREAMING_SNAKE_CASE) violates this convention
and is renamed to LogoImage at both the definition and its two usages.

Affected file:

  • admin.core.v1/components/header.tsx (lines 632, 633)

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Developer Checklist (Mandatory)

  • Complete the Developer Checklist in the related product-is issue to track any behavioral change or migration impact.

No behavioural change, migration impact, or new configuration introduced by this fix.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 3b5e612b-8a34-4ff0-abc1-e944584b3efd

📥 Commits

Reviewing files that changed from the base of the PR and between 0651514 and 977aba6.

📒 Files selected for processing (2)
  • .changeset/fix-jsx-pascal-case.md
  • features/admin.core.v1/components/header.tsx

📝 Walkthrough

Walkthrough

Renames the local logo helper component in header.tsx from LOGO_IMAGE to LogoImage to comply with JSX PascalCase naming conventions, updating both the declaration and two usage sites. A changeset patch entry is added for @wso2is/admin.core.v1.

Changes

JSX PascalCase rename

Layer / File(s) Summary
Component rename and changeset
features/admin.core.v1/components/header.tsx, .changeset/fix-jsx-pascal-case.md
Renames the local logo helper from LOGO_IMAGE to LogoImage at the declaration (line 551) and both OxygenHeader brand logo usages (desktop and mobile). Adds a changeset patch entry documenting the rename.

Suggested reviewers

  • JayaShakthi97
  • Lakshan-Banneheke
  • lashinijay
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: renaming LOGO_IMAGE to LogoImage to fix the JSX PascalCase warning.
Description check ✅ Passed The PR description follows the template and includes purpose, related issue, checklist, and security sections with a clear summary.
Linked Issues check ✅ Passed The change renames LOGO_IMAGE to LogoImage in header.tsx and updates both occurrences, matching issue #27900.
Out of Scope Changes check ✅ Passed Only the requested rename and its changeset entry were added, with no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Changeset Required ✅ Passed PASS: The PR includes .changeset/fix-jsx-pascal-case.md (not README) with a patch entry for @wso2is/admin.core.v1.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ create changeset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[React Doctor] jsx-pascal-case: JSX component LOGO_IMAGE must be in PascalCase (2 occurrences)

1 participant