Skip to content

Handle null request body in Organization management POST endpoints #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruchiralakshan123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle null request body in Organization management POST endpoints #1147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...identity/api/server/organization/management/v1/service/OrganizationManagementService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,10 @@ public Response updateOrganization(String organizationId, OrganizationPUTRequest
public Response addOrganization(OrganizationPOSTRequest organizationPOSTRequest) {

try {
if (organizationPOSTRequest == null) {
throw new OrganizationManagementClientException("Empty request body.",
"The request body cannot be empty or null.", "ORG-60025");
}
Organization organization = organizationManager.addOrganization(getOrganizationFromPostRequest
(organizationPOSTRequest));
String organizationId = organization.getId();
Expand Down Expand Up @@ -415,6 +419,10 @@ public Response addOrganizationDiscoveryAttributes(OrganizationDiscoveryPostRequ
organizationDiscoveryPostRequest) {

try {
if (organizationDiscoveryPostRequest == null) {
throw new OrganizationManagementClientException("Empty request body.",
"The request body cannot be empty or null.", "ORG-60025");
}
List<OrgDiscoveryAttribute> orgDiscoveryAttributeList = organizationDiscoveryManager
.addOrganizationDiscoveryAttributes(organizationDiscoveryPostRequest.getOrganizationId(),
getOrgDiscoveryAttributesFromPostRequest(organizationDiscoveryPostRequest), true);
Expand Down Expand Up @@ -549,6 +557,10 @@ public Response isDiscoveryAttributeAvailable(OrganizationDiscoveryCheckPOSTRequ
organizationDiscoveryCheckPOSTRequest) {

try {
if (organizationDiscoveryCheckPOSTRequest == null) {
throw new OrganizationManagementClientException("Empty request body.",
"The request body cannot be empty or null.", "ORG-60025");
}
boolean discoveryAttributeValueAvailable = organizationDiscoveryManager
.isDiscoveryAttributeValueAvailable(organizationDiscoveryCheckPOSTRequest.getType(),
organizationDiscoveryCheckPOSTRequest.getValue());
Expand Down