Fix duplicate livenessProbe in key-manager deployment

[Copilot]

Purpose

The key-manager deployment template contained two livenessProbe definitions where the second should have been a readinessProbe.

Goals

Correct the probe configuration to match the pattern used across all other deployment templates in the repository.

Approach

Changed the second probe definition from livenessProbe to readinessProbe and updated its configuration references to use .Values.wso2.deployment.readinessProbe.* instead of .Values.wso2.deployment.livenessProbe.*.

File changed: distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml

# Before (line 163)
livenessProbe:
  httpGet:
    path: /services/Version
    port: {{ add 9763 .Values.wso2.apim.portOffset }}
  initialDelaySeconds: {{ .Values.wso2.deployment.livenessProbe.initialDelaySeconds }}
  periodSeconds: {{ .Values.wso2.deployment.livenessProbe.periodSeconds }}
  failureThreshold: {{ .Values.wso2.deployment.livenessProbe.failureThreshold }}

# After (line 163)
readinessProbe:
  httpGet:
    path: /services/Version
    port: {{ add 9763 .Values.wso2.apim.portOffset }}
  initialDelaySeconds: {{ .Values.wso2.deployment.readinessProbe.initialDelaySeconds }}
  periodSeconds: {{ .Values.wso2.deployment.readinessProbe.periodSeconds }}
  failureThreshold: {{ .Values.wso2.deployment.readinessProbe.failureThreshold }}

User stories

N/A - Configuration bug fix

Release note

Fixed duplicate livenessProbe in key-manager deployment; second probe correctly configured as readinessProbe

Documentation

N/A - Internal deployment configuration fix with no user-facing documentation impact

Training

N/A

Certification

N/A - Internal configuration correction

Marketing

N/A

Automation tests

• Unit tests

  Validated with helm lint - no errors

• Integration tests

  N/A - Configuration fix only

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
• Ran FindSecurityBugs plugin and verified report? N/A - YAML configuration only
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

None

Migrations (if applicable)

No migration required - Helm will apply corrected probe configuration on next deployment

Test environment

Validated with Helm v3.x

Learning

Referenced existing deployment patterns from control-plane, gateway, and traffic-manager templates to ensure consistency

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[kavindasr]

@RakhithaRR, @copilot apply the same fix for 4.4.x, 4.5.x and 4.6.x branches

[Copilot]

@RakhithaRR, @copilot apply the same fix for 4.4.x, 4.5.x and 4.6.x branches

I'm unable to create separate PRs or push to multiple branches. To apply this fix to the 4.4.x, 4.5.x, and 4.6.x branches, you would need to:

1. Cherry-pick commit ced25db to each branch, or
2. Manually apply the same change to distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml in each branch (changing the second livenessProbe to readinessProbe with corresponding value references)

Would you like me to provide specific instructions or create separate issues for tracking each branch?