Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs on RC4 depreciation. #6179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Update docs on RC4 depreciation. #6179
Changes from all commits
d3e61cdFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 76 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Fenced code blocks should be surrounded by blank lines
Check warning on line 90 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Check warning on line 90 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Check failure on line 95 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Fenced code blocks should be surrounded by blank lines
Check failure on line 97 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Fenced code blocks should be surrounded by blank lines
Check failure on line 109 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Fenced code blocks should be surrounded by blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix MD031 failures by adding blank lines around fenced blocks in both Jinja branches.
The fences opened at Line 76 and Line 97 are not surrounded by blank lines, which is causing the lint job to fail.
Suggested patch
{% if is_version in ["7.0.0", "7.1.0", "7.2.0"] %} + ``` java [libdefaults] default_realm = WSO2.COM @@ } ``` + The default configuration uses `rc4-hmac`, which is considered weak and is disabled by default in newer JDKs. Update `default_tkt_enctypes` and `default_tgs_enctypes` to use AES enctypes that are also permitted for the SPN account on your KDC. For most Active Directory environments, the following is a safe replacement: @@ default_tgs_enctypes = aes256-cts-hmac-sha1-96 aes128-cts-hmac-sha1-96 ``` + {% else %} + ``` java [libdefaults] default_realm = WSO2.COM @@ } ``` + {% endif %}🧰 Tools
🪛 GitHub Actions: Markdown Lint / 0_lint.txt
[error] 76-76: markdownlint-cli2: MD031/blanks-around-fences - Fenced code blocks should be surrounded by blank lines. [Context: "``` java"]
🪛 GitHub Actions: Markdown Lint / lint
[error] 76-76: markdownlint-cli2/md031: Fenced code blocks should be surrounded by blank lines [Context: "``` java"].
🪛 GitHub Check: lint
[failure] 109-109: Fenced code blocks should be surrounded by blank lines
en/includes/guides/authentication/enterprise-login/add-iwa-login.md:109 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md031.md
[failure] 97-97: Fenced code blocks should be surrounded by blank lines
en/includes/guides/authentication/enterprise-login/add-iwa-login.md:97 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "``` java"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md031.md
[failure] 95-95: Fenced code blocks should be surrounded by blank lines
en/includes/guides/authentication/enterprise-login/add-iwa-login.md:95 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md031.md
[failure] 76-76: Fenced code blocks should be surrounded by blank lines
en/includes/guides/authentication/enterprise-login/add-iwa-login.md:76 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "``` java"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md031.md
🤖 Prompt for AI Agents
Sources: Linters/SAST tools, Pipeline failures
Check warning on line 117 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Check warning on line 118 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Check warning on line 127 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Check warning on line 136 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Check warning on line 140 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Check failure on line 263 in en/includes/guides/authentication/enterprise-login/add-iwa-login.md
Link fragments should be valid
Uh oh!
There was an error while loading. Please reload this page.