Skip to content

ci(helm): accept non-v-prefixed appVersion in release workflow#2744

Merged
DDH13 merged 1 commit into
wso2:mainfrom
renuka-fernando:ci-fix-helm-release-appversion-regex
Jul 18, 2026
Merged

ci(helm): accept non-v-prefixed appVersion in release workflow#2744
DDH13 merged 1 commit into
wso2:mainfrom
renuka-fernando:ci-fix-helm-release-appversion-regex

Conversation

@renuka-fernando

Copy link
Copy Markdown
Contributor

Purpose

The gateway Helm release workflow fails at the Validate input formats step for every valid input, blocking releases.

PR #2646 added an input-format guard whose appVersion regex requires a leading v (^v[0-9]...), with a v1.0.0-m4 example. However, the gateway release convention has never used a v prefix: the last successful release (1.1.0) used appVersion 1.1.0, and all published image tags on ghcr.io are non-prefixed (gateway-controller:1.2.0-alpha2 exists; v1.2.0-alpha2 returns 404). The guard therefore rejects every appVersion that could actually match a published image, and it broke the workflow on its first run after merge.

Approach

  • Drop the v requirement from the appVersion regex (^v[0-9]...^[0-9]...), restoring the behavior that released 1.1.0.
  • Correct the error message to reference non-prefixed semver.
  • Correct the appVersion input hint from v1.0.0-m4 to 1.0.0-m4.

The shell-injection hardening from #2646 (env-var indirection, quoted tag refs, explicit tag step) is unaffected and retained.

Related Issues

N/A

Checklist

  • Tests added or updated (unit, integration, etc.)
  • Samples updated (if applicable)

PR wso2#2646 added an input-format guard whose appVersion regex required a
leading "v" (^v[0-9]...), but the gateway release convention has never
used a v prefix — the 1.1.0 release and all published image tags are
non-prefixed. The guard rejected every valid appVersion, breaking the
release workflow on its first run after merge.

- Drop the "v" requirement from the appVersion regex
- Correct the error message and input hint to non-prefixed examples
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a5a8ae6f-e5ba-47ca-9b96-2c7e04ec6cf7

📥 Commits

Reviewing files that changed from the base of the PR and between db88a9d and 0c21ec9.

📒 Files selected for processing (1)
  • .github/workflows/gateway-helm-release.yml

📝 Walkthrough

Walkthrough

The gateway Helm release workflow now documents and validates appVersion and APP_VERSION as non-v-prefixed semantic versions.

Changes

Gateway Helm release versioning

Layer / File(s) Summary
Align version input and validation
.github/workflows/gateway-helm-release.yml
The workflow input example, semantic version regex, and validation error message now use non-v-prefixed versions.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: anugayan, arshardh, crowleyrajapakse

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description covers Purpose and Approach, but it omits several required template sections like Goals, tests, documentation, security checks, and test environment. Add the missing template sections with brief details: Goals, Documentation, Automation tests, Security checks, Samples, Related PRs, and Test environment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the workflow change to accept non-v-prefixed appVersion values.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DDH13
DDH13 merged commit 5f8e7f8 into wso2:main Jul 18, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants