ci(helm): accept non-v-prefixed appVersion in release workflow#2744
Merged
DDH13 merged 1 commit intoJul 18, 2026
Merged
Conversation
PR wso2#2646 added an input-format guard whose appVersion regex required a leading "v" (^v[0-9]...), but the gateway release convention has never used a v prefix — the 1.1.0 release and all published image tags are non-prefixed. The guard rejected every valid appVersion, breaking the release workflow on its first run after merge. - Drop the "v" requirement from the appVersion regex - Correct the error message and input hint to non-prefixed examples
renuka-fernando
requested review from
AnuGayan,
Arshardh,
CrowleyRajapakse,
HeshanSudarshana,
HiranyaKavishani,
Induwara04,
Krishanx92,
PasanT9,
Piumal1999,
RakhithaRR,
Tharsanan1,
Thushani-Jayasekera,
VirajSalaka,
ashera96,
chamilaadhi,
dushaniw,
hisanhunais,
lasanthaS,
malinthaprasan,
pubudu538,
senthuran16,
tgtshanika,
tharikaGitHub,
tharindu1st and
thivindu
as code owners
July 18, 2026 08:08
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe gateway Helm release workflow now documents and validates ChangesGateway Helm release versioning
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DDH13
approved these changes
Jul 18, 2026
Krishanx92
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The gateway Helm release workflow fails at the
Validate input formatsstep for every valid input, blocking releases.PR #2646 added an input-format guard whose
appVersionregex requires a leadingv(^v[0-9]...), with av1.0.0-m4example. However, the gateway release convention has never used avprefix: the last successful release (1.1.0) used appVersion1.1.0, and all published image tags on ghcr.io are non-prefixed (gateway-controller:1.2.0-alpha2exists;v1.2.0-alpha2returns 404). The guard therefore rejects every appVersion that could actually match a published image, and it broke the workflow on its first run after merge.Approach
vrequirement from theappVersionregex (^v[0-9]...→^[0-9]...), restoring the behavior that released1.1.0.appVersioninput hint fromv1.0.0-m4to1.0.0-m4.The shell-injection hardening from #2646 (env-var indirection, quoted tag refs, explicit tag step) is unaffected and retained.
Related Issues
N/A
Checklist