Skip to content

[Devportal] Remove type field from key manager configurations#2656

Merged
lasanthaS merged 1 commit into
wso2:mainfrom
Piumal1999:rm-km-type
Jul 15, 2026
Merged

[Devportal] Remove type field from key manager configurations#2656
lasanthaS merged 1 commit into
wso2:mainfrom
Piumal1999:rm-km-type

Conversation

@Piumal1999

Copy link
Copy Markdown
Contributor

Purpose

Remove type field from key manager configurations

Approach

Removed the column and its references as we are not using the type currently

Related PRs

N/A

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3637f546-0ccd-41c9-9ce0-353f3ee0bec8

📥 Commits

Reviewing files that changed from the base of the PR and between ab1d715 and 6b04737.

📒 Files selected for processing (11)
  • docs/rest-apis/devportal/key-managers.md
  • docs/rest-apis/devportal/schemas.md
  • portals/developer-portal/database/schema.postgres.sql
  • portals/developer-portal/docs/administer/key-manager-integration.md
  • portals/developer-portal/docs/devportal-openapi-spec-v0.9.yaml
  • portals/developer-portal/it/rest-api/key-managers/key-managers.spec.js
  • portals/developer-portal/it/rest-api/key-managers/token-generation.spec.js
  • portals/developer-portal/src/dao/keyManagerDao.js
  • portals/developer-portal/src/dto/keyManagerDto.js
  • portals/developer-portal/src/models/keyManager.js
  • portals/developer-portal/src/services/keyManagerService.js
💤 Files with no reviewable changes (6)
  • portals/developer-portal/src/dto/keyManagerDto.js
  • portals/developer-portal/src/models/keyManager.js
  • portals/developer-portal/src/dao/keyManagerDao.js
  • docs/rest-apis/devportal/schemas.md
  • docs/rest-apis/devportal/key-managers.md
  • portals/developer-portal/docs/devportal-openapi-spec-v0.9.yaml

📝 Walkthrough

Walkthrough

The developer portal removes the key manager type field from persistence, service handling, DTOs, OpenAPI contracts, REST documentation, and integration tests. Key managers are documented and tested as OAuth2 client_credentials providers.

Changes

Key Manager Type Removal

Layer / File(s) Summary
Persistence and service removal
portals/developer-portal/database/schema.postgres.sql, portals/developer-portal/src/models/keyManager.js, portals/developer-portal/src/dao/keyManagerDao.js, portals/developer-portal/src/services/keyManagerService.js
The database schema, Sequelize model, DAO operations, and service payload handling no longer store, assign, or update type.
Response contracts and documentation
portals/developer-portal/src/dto/keyManagerDto.js, portals/developer-portal/docs/devportal-openapi-spec-v0.9.yaml, docs/rest-apis/devportal/*.md, portals/developer-portal/docs/administer/key-manager-integration.md
Full and public DTOs, OpenAPI schemas, examples, property tables, and integration guidance no longer expose or document type.
Integration test alignment
portals/developer-portal/it/rest-api/key-managers/*.spec.js
Tests stop sending or asserting type and remove the default-type verification case.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: lasanthas, rakhitharr, tharsanan1

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers purpose and approach, but omits several required template sections like goals, tests, security, and environment. Add the missing template sections: Goals, User stories, Documentation, Automation tests, Security checks, Samples, and Test environment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: removing the key manager type field.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lasanthaS
lasanthaS merged commit 5e7bbe0 into wso2:main Jul 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants