sdk changes to retrieve upstrem#2577
Merged
Merged
Conversation
tharindu1st
requested review from
AnuGayan,
Arshardh,
CrowleyRajapakse,
HeshanSudarshana,
HiranyaKavishani,
Krishanx92,
PasanT9,
RakhithaRR,
Tharsanan1,
Thushani-Jayasekera,
VirajSalaka,
ashera96,
chamilaadhi,
dushaniw,
hisanhunais,
lasanthaS,
malinthaprasan,
pubudu538,
renuka-fernando,
senthuran16,
tgtshanika,
tharikaGitHub and
thivindu
as code owners
July 10, 2026 05:00
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds ChangesUpstream routing policy support
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Krishanx92
approved these changes
Jul 10, 2026
| // These are valid at the header phase because routing decisions do not require | ||
| // the request body to be available. | ||
| UpstreamName *string // route to a named upstream definition (nil = no change) | ||
| UpstreamSlot *UpstreamSlot // route to the API's main or sandbox upstream slot instead of the slot implied by the current vhost (nil = no change); requesting a slot the API doesn't have configured is a no-op (logged, not an error) |
Contributor
There was a problem hiding this comment.
This is not required right?
| // URL. This is the shared wire shape used on both sides of the xDS route-config | ||
| // channel between gateway-controller and policy-engine. | ||
| type UpstreamInfo struct { | ||
| ClusterName string `json:"cluster_name" yaml:"cluster_name"` |
Contributor
There was a problem hiding this comment.
ClusterName is an internal thing. Why do we need to expose it?
| // ToMap converts UpstreamInfo into a structpb-compatible map for embedding as a | ||
| // nested object in xDS route-config metadata (structpb.Struct only accepts | ||
| // string/bool/number/nil/slice/map values, not arbitrary structs). | ||
| func (u UpstreamInfo) ToMap() map[string]interface{} { |
Contributor
There was a problem hiding this comment.
Why do we need this func?
|
|
||
| // UpstreamInfoFromMap decodes an UpstreamInfo from the generic map produced when | ||
| // the xDS metadata struct is unmarshalled back to JSON on the consumer side. | ||
| func UpstreamInfoFromMap(m map[string]interface{}) UpstreamInfo { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdk changes to retrieve upstrem