Skip to content

Fix failing devportal e2e test#2542

Merged
lasanthaS merged 1 commit into
wso2:mainfrom
Piumal1999:fix-e2e-sp
Jul 8, 2026
Merged

Fix failing devportal e2e test#2542
lasanthaS merged 1 commit into
wso2:mainfrom
Piumal1999:fix-e2e-sp

Conversation

@Piumal1999

Copy link
Copy Markdown
Contributor

Purpose

Fixing the failing E2E test

Approach

The test was failing due to a change in the environment variable naming convention. The issue was fixed by updating the test configuration.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ef47c046-f565-4b50-84fc-40b9a6fdafe1

📥 Commits

Reviewing files that changed from the base of the PR and between 3366fe7 and ff0e1e3.

📒 Files selected for processing (3)
  • tests/integration-e2e/README.md
  • tests/integration-e2e/docker-compose.yaml
  • tests/integration-e2e/steps_devportal_test.go

📝 Walkthrough

Walkthrough

Renamed devportal environment variables from a DP_* prefix to APIP_DP_* in the integration-e2e docker-compose configuration, covering database connection, base URL/TLS, organization seeding, JWT validation, and encryption settings. Updated corresponding documentation and code comments in README and test files.

Changes

Devportal Environment Variable Rename

Layer / File(s) Summary
Docker-compose env var rename
tests/integration-e2e/docker-compose.yaml
Renamed devportal DB, base URL/TLS, organization, subscription-plan, JWT, and encryption key env vars from DP_* to APIP_DP_*.
Docs and comment updates
tests/integration-e2e/README.md, tests/integration-e2e/steps_devportal_test.go
Updated documentation and inline comments to reference the new APIP_DP_* variable names for JWT secret and default org name.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • wso2/api-platform#2471: Introduced the devportal E2E stack with the original DP_* env var naming that this PR renames.

Suggested reviewers: RakhithaRR, Tharsanan1, VirajSalaka, tharindu1st, malinthaprasan

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers purpose and approach, but omits most required template sections like goals, tests, security checks, docs, and test environment. Fill in the missing template sections: Goals, User stories, Documentation, Automation tests, Security checks, Samples, Related PRs, and Test environment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: fixing the failing devportal E2E test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lasanthaS
lasanthaS merged commit e653383 into wso2:main Jul 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants