Skip to content

Implement multi-device push authentication with enhanced logging#26

Merged
ZiyamSanthosh merged 1 commit into
wso2-extensions:mainfrom
raviendalpatadu:feature/ravien-push-auth-for-multiple-devices-support
Jul 16, 2026
Merged

Implement multi-device push authentication with enhanced logging#26
ZiyamSanthosh merged 1 commit into
wso2-extensions:mainfrom
raviendalpatadu:feature/ravien-push-auth-for-multiple-devices-support

Conversation

@raviendalpatadu

@raviendalpatadu raviendalpatadu commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces new device management configuration capabilities and enhances device-related APIs and constants in the push device handler module. The changes include support for managing device enrollment settings per tenant, improved error handling, and additional DAO methods for handling multiple devices per user.

Device management configuration and API enhancements:

  • Added new methods to DeviceHandlerService to get and update device management configurations (getDeviceManagementConfig, updatePushDeviceMgtConfigs), and to retrieve all devices for a user (getDevicesByUserId). Method signatures were updated to consistently include tenantDomain as a parameter.

  • Introduced new constants in PushDeviceHandlerConstants for device management configuration keys, resource identifiers, attribute keys, and notification settings. Added nested classes for email and push notification related constants.

  • Expanded the ErrorMessages enum to include error codes and messages related to device management configuration retrieval, update, validation, and device registration limits.

DAO and implementation updates:

  • Updated the DeviceDAO interface and DeviceDAOImpl to support retrieving all devices for a user (getDevicesByUserId) and to accept/throw the more general PushDeviceHandlerException for registration.

  • Enhanced error handling in DeviceDAOImpl.registerDevice to throw a client exception with a specific error code/message if a device ID is already registered (SQL state "23" constraint violation).

Dependency and OSGi configuration:

  • Added a dependency on org.wso2.carbon.identity.configuration.mgt.core and updated OSGi import packages to include configuration management and event/notification related packages in the module's pom.xml.

Related Issue

@CLAassistant

CLAassistant commented Jun 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@raviendalpatadu
raviendalpatadu force-pushed the feature/ravien-push-auth-for-multiple-devices-support branch from c3b325e to e8bf1e5 Compare June 19, 2026 12:03

// Details of the newly registered device rendered in the notification.
properties.put(PushDeviceHandlerConstants.PushNotificationConstants.DEVICE_NAME_PLACEHOLDER,
StringUtils.defaultString(registeredDevice.getDeviceName()));

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this

@raviendalpatadu
raviendalpatadu force-pushed the feature/ravien-push-auth-for-multiple-devices-support branch from 81bef8b to d2f53e3 Compare July 15, 2026 20:10
@raviendalpatadu
raviendalpatadu force-pushed the feature/ravien-push-auth-for-multiple-devices-support branch from d2f53e3 to d508a40 Compare July 16, 2026 03:26
@jenkins-is-staging

Copy link
Copy Markdown

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/29469324244

@jenkins-is-staging

Copy link
Copy Markdown

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/29469324244
Status: failure

@raviendalpatadu

Copy link
Copy Markdown
Contributor Author

@ZiyamSanthosh
ZiyamSanthosh merged commit 5ce20fe into wso2-extensions:main Jul 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants