Implement multi-device push authentication with enhanced logging#26
Merged
ZiyamSanthosh merged 1 commit intoJul 16, 2026
Conversation
raviendalpatadu
force-pushed
the
feature/ravien-push-auth-for-multiple-devices-support
branch
from
June 19, 2026 12:03
c3b325e to
e8bf1e5
Compare
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 24, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jun 25, 2026
raviendalpatadu
commented
Jul 15, 2026
raviendalpatadu
commented
Jul 15, 2026
|
|
||
| // Details of the newly registered device rendered in the notification. | ||
| properties.put(PushDeviceHandlerConstants.PushNotificationConstants.DEVICE_NAME_PLACEHOLDER, | ||
| StringUtils.defaultString(registeredDevice.getDeviceName())); |
raviendalpatadu
commented
Jul 15, 2026
raviendalpatadu
commented
Jul 15, 2026
raviendalpatadu
commented
Jul 15, 2026
raviendalpatadu
force-pushed
the
feature/ravien-push-auth-for-multiple-devices-support
branch
from
July 15, 2026 20:10
81bef8b to
d2f53e3
Compare
raviendalpatadu
force-pushed
the
feature/ravien-push-auth-for-multiple-devices-support
branch
from
July 16, 2026 03:26
d2f53e3 to
d508a40
Compare
|
PR builder started |
|
PR builder completed |
Contributor
Author
|
ran integration tests in the fork |
ZiyamSanthosh
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new device management configuration capabilities and enhances device-related APIs and constants in the push device handler module. The changes include support for managing device enrollment settings per tenant, improved error handling, and additional DAO methods for handling multiple devices per user.
Device management configuration and API enhancements:
Added new methods to
DeviceHandlerServiceto get and update device management configurations (getDeviceManagementConfig,updatePushDeviceMgtConfigs), and to retrieve all devices for a user (getDevicesByUserId). Method signatures were updated to consistently includetenantDomainas a parameter.Introduced new constants in
PushDeviceHandlerConstantsfor device management configuration keys, resource identifiers, attribute keys, and notification settings. Added nested classes for email and push notification related constants.Expanded the
ErrorMessagesenum to include error codes and messages related to device management configuration retrieval, update, validation, and device registration limits.DAO and implementation updates:
Updated the
DeviceDAOinterface andDeviceDAOImplto support retrieving all devices for a user (getDevicesByUserId) and to accept/throw the more generalPushDeviceHandlerExceptionfor registration.Enhanced error handling in
DeviceDAOImpl.registerDeviceto throw a client exception with a specific error code/message if a device ID is already registered (SQL state "23" constraint violation).Dependency and OSGi configuration:
org.wso2.carbon.identity.configuration.mgt.coreand updated OSGi import packages to include configuration management and event/notification related packages in the module'spom.xml.Related Issue