Support array-based key bindings (execute multiple commands) - #235
Open
Yaruani wants to merge 2 commits into
Open
Support array-based key bindings (execute multiple commands)#235Yaruani wants to merge 2 commits into
Yaruani wants to merge 2 commits into
Conversation
Changed the "Keys" type definition from "string" to "any" to support array-based command sequences and prevent validation errors.
Modified buildKeyCommand to handle both string and array inputs. If an array is provided, it iterates through and executes each command in sequence.
wshanks
reviewed
Feb 16, 2026
wshanks
left a comment
wshanks
left a comment
Owner
There was a problem hiding this comment.
This looks nice. Can you also add something to the "Command syntax" section of the readme about using arrays of strings instead of single strings?
| // This function is based on the default callback in Mousetrap but is extended | ||
| // to include more text input fields that are specific to Thunderbird. | ||
| // Additionally, it does not ignore text fields if the first key includes | ||
| // modifiers other than shift. |
Owner
There was a problem hiding this comment.
I don't think this comment needed to be removed?
Comment on lines
+96
to
+97
| // command should be a string formatted as type:body OR an array of strings. | ||
| // Modified to support multiple commands in an array. |
Owner
There was a problem hiding this comment.
I'd like to keep the description of the string formatting (line wrapping might not be right for this suggestion):
Suggested change
| // command should be a string formatted as type:body OR an array of strings. | |
| // Modified to support multiple commands in an array. | |
| // command should be a string or arrays of strings with | |
| // each string formatted as type:body where type is cmd, func, | |
| // tbkeys, unset, or eval and body is the type-specific content of the command |
| eval(command); | ||
| break; | ||
| // Internal helper to execute a single command string | ||
| const runSingleCommand = (cmdStr) => { |
Owner
There was a problem hiding this comment.
Can we pull this definition outside of buildKeyCommand?
| // | ||
| // keyBindings has the structure: | ||
| // {windowType: {keySequence: keyCommand}} | ||
| // {windowType: {keySequence: keyCommand}} |
Owner
There was a problem hiding this comment.
Maybe undo this change unless there was a reason for it?
| "type": "object", | ||
| "description": "Mapping of key sequences to commands", | ||
| "additionalProperties": { "type": "string" } | ||
| "additionalProperties": { "type": "any" } |
Owner
There was a problem hiding this comment.
We are going from allowing strings to allow arrays of strings. Can we keep the schema more restricted to those cases instead of using any?
Suggested change
| "additionalProperties": { "type": "any" } | |
| "additionalProperties": { "type": ["array", "string"], "items": {"type": "string"} } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great addon.
I found that using an array for key bindings (e.g.,
["cmd:A", "cmd:B"]) was causing errors due to schema validation and implementation logic.I have updated
implementation.jsandschema.jsonto support array-based commands properly.This allows users to execute multiple commands with a single key press (e.g., Mark as Read -> Archive).
Please review the changes. Thanks!