Repository navigation
1.47.0: Electron 44.10.0 - #67
Merged
Merged
Conversation
Runtime update on its own, so a regression has one cause. Electron 44
changed the clipboard module to the W3C shape:
- clipboard.readText() is a Promise now → clipboardInvite() is async
(interface, implementation, three tests).
- clipboard.readImage() / writeImage() are gone → src/main/clipboardImage.ts
reads the image through clipboard.read() + ClipboardItem.getType('image/png')
and writes through clipboard.write(). Verified with a real Electron 44 on
Windows: a bitmap put on the clipboard by PowerShell reads as image/png at
20x10; a 3x4 PNG written by DevDeck reads back at 3x4. The three handlers
(clipboard:readImage, readImageBytes, writeImage) call the helper; the
guard tests mock it.
- macOS 13+ is now required (Electron 44 dropped macOS 12). x64-only
builds, no openAsHidden, no electron import in the renderer: nothing else
in the breaking-changes list applies.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016NLGwiBY5uEivJqERQzcoY
CI's Windows journeys failed on `clipboard.readImage is not a function`: the harnesses saved, checked and restored the clipboard image through the removed readImage()/writeImage(). They now go through read() / write() + ClipboardItem, as the app does. image-rows passes locally on 44.10.0; link.mjs is the local two-instance script (not run in CI). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016NLGwiBY5uEivJqERQzcoY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Electron 43.8.4 → 44.10.0 (Chromium 152, Node.js 24), as its own release so a regression has one cause. Replaces Dependabot's #50 (44.9.0), whose CI failed in every job.
Breaking changes that applied
clipboard.readText()returns a Promise →LinkService.clipboardInvite()is async (interface + 3 tests).clipboard.readImage()/writeImage()removed → newsrc/main/clipboardImage.ts(readClipboardPngviaclipboard.read()+ClipboardItem.getType('image/png'),writeClipboardPngviaclipboard.write()). Handlersclipboard:readImage,clipboard:readImageBytes,clipboard:writeImageuse it;ipc.guard.testmocks it.Checked and not applicable: 32-bit builds (x64 only),
openAsHidden(not used),clipboardin renderer (renderer imports nothing from electron).Verified
image/png20×10 (111 bytes); a 3×4 PNG written throughclipboard.writereads back at 3×4 (95 bytes);readText()is a Promise.npm audit --audit-level=highclean.🤖 Generated with Claude Code
https://claude.ai/code/session_016NLGwiBY5uEivJqERQzcoY