Repository navigation
1.45.1: don't offer background sessions whose folder is gone; say so when a session's folder is missing - #64
Merged
Merged
Conversation
… why
Reported: "Could not open session in C:\...\3d-asset-studio: Cannot create process, error
code: 267". `claude agents --json --all` still listed a background session from July
(state blocked) whose folder had been deleted; attaching starts in that folder, and
Windows refused (ERROR_DIRECTORY). agents:background now drops entries whose cwd is not a
directory, and cockpit:open answers OPEN_FOLDER_MISSING for any session whose folder is
gone, which the opener words ("its folder no longer exists: <path>").
The open tests named project folders that never existed; they now use real temp folders.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016NLGwiBY5uEivJqERQzcoY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016NLGwiBY5uEivJqERQzcoY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported:
Cause, confirmed on the reporter's PC:
claude agents --json --alllists background session09644674("customer support response clarification"), stateblocked, started in July in…\GitHub\3d-asset-studio. That folder no longer exists. DevDeck spawnsclaude attach <id>with the session's folder as the working directory, and Windows refuses a missing folder withERROR_DIRECTORY(267). The 1.44.0 listing checked that the folder was inside an allowed folder, but not that it still existed.Fix:
agents:backgrounddrops entries whosecwdis not an existing directory.cockpit:openchecks the project folder before spawning. If it is gone, the answer isOPEN_FOLDER_MISSINGand no terminal is started. The opener shows "its folder no longer exists: (deleted or moved)", in 4 languages, instead of the raw Windows error code.Tests:
pty.create. The background listing keeps the session in an existing folder and drops the one in a deleted folder.<cwd>/allowed-root). They now use real temp folders, removed afterwards.vitest: 1528 passed.tscclean.qa:cockpit-tools: its background-session check passes.🤖 Generated with Claude Code
https://claude.ai/code/session_016NLGwiBY5uEivJqERQzcoY