Repository navigation
chore(deps): axe-core 4.14, esbuild 0.28.2, playwright 1.64.1 + sidebar accessible names - #61
Merged
Conversation
…r names match what is shown
axe-core 4.14 checks WCAG 2.5.3 (label-content-name-mismatch), and the sidebar failed it in
three places. A voice-control user says what they see, so the accessible name has to
contain the visible words, in order:
- group toggles ("프로젝트" + "1"): the name and count rendered as one word; a space between
them (flex drops it from layout), and the collapsed name uses the count as shown ("2/5");
- session rows: the state sat between the detail and the summary; it now comes last;
- project rows: the branch line was not in the name at all.
The audit now logs each failing element's HTML, not just its selector.
Supersedes #49, #51, #52.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016NLGwiBY5uEivJqERQzcoY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Dependabot #49, #51 and #52 with one change on current main. Their branches predate the macOS runner outage and #49 failed the accessibility audit.
Why #49 failed: axe-core 4.14 checks WCAG 2.5.3 (
label-content-name-mismatch): an element's accessible name has to contain its visible text, in order. Someone using voice control says what they see. The sidebar failed it in three places:The audit also logs each failing element's HTML now. Before, it printed only a selector.
Checked locally (Windows):
qa/audit.mjswith axe 4.14: 0 violations on every view and dialog.vitest: 1510 passed.tscclean.qa/resilience.mjs: 9/9 passed.libcfields are kept.🤖 Generated with Claude Code
https://claude.ai/code/session_016NLGwiBY5uEivJqERQzcoY