Skip to content

Update cVszArchive.cls to add Unicode Support to "Addfiles" - #5

Open
Hobbybyte wants to merge 1 commit into
wqweto:masterfrom
Hobbybyte:Unicode-Support-for-AddFile
Open

Update cVszArchive.cls to add Unicode Support to "Addfiles"#5
Hobbybyte wants to merge 1 commit into
wqweto:masterfrom
Hobbybyte:Unicode-Support-for-AddFile

Conversation

@Hobbybyte

Copy link
Copy Markdown

Added Unicode Support for Creating Archives
Changing FindFirstFileA to FindFirstFileW in Function AddFiles

Thanks for creating and sharing such a great vb code

@wqweto

wqweto commented Apr 19, 2023

Copy link
Copy Markdown
Owner

Current WIN32_FIND_DATA declaration uses String members which get ANSI<->Unicode transcoded which is a problem for Unicode API functions (like FindFirstFileW) which do not need any transcoding to happen at callsite.

To prevent this auto-transcoding the last parameter of FindFirstFile API declare should become ByVal lpFindFileData As Long and callsite should use VarPtr(uData) for actual argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants