Create test.spec.js#24
Conversation
|
copilot:summary |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
|
@copilot Add 5 intentional bugs to this PR |
|
@wpscholar I've opened a new pull request, #25, to work on those changes. Once the pull request is ready, I'll request review from you. |
wpscholar
left a comment
There was a problem hiding this comment.
Summary:
- Test structure looks good; suggested using Cypress each for more predictable command sequencing.
- Performance marks/measures can accumulate across visits; consider clearing or using unique marks to avoid stale entries.
| .then( | ||
| (entries) => { | ||
| entries | ||
| .forEach( |
There was a problem hiding this comment.
Consider using cy.wrap(entries).each(...) instead of forEach. Cypress recommends each for command sequencing; forEach can make command ordering and failures harder to reason about when iterating.
| .its('performance') | ||
| .then((performance) => { | ||
| performance.measure('pageLoad', 'start-loading', 'end-loading'); | ||
| const measure = performance.getEntriesByName('pageLoad')[0]; |
There was a problem hiding this comment.
Since this runs multiple cy.visit calls, the performance entries will accumulate. Either clear marks/measures before each visit (performance.clearMarks()/clearMeasures()), use unique mark names per URL, or grab the last entry from getEntriesByName instead of [0] to avoid stale measurements.
Proposed changes
copilot:summary
Type of Change
Checklist
Further comments