Skip to content

fix(apl): escape validation text before it becomes tooltip HTML #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1337LutZ merged 1 commit into from
Sep 9, 2026
+7 −1
Merged

fix(apl): escape validation text before it becomes tooltip HTML #1536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ui/core/components/pickers/list_picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ interface ListDragData<ModObject, ItemType> {

let curDragData: ListDragData<any, any> | null = null;

// The sim formats user-authored APL group and variable names into its validation strings, and
// tippy's global `allowHTML: true` renders the tooltip as markup, so a shared rotation could
// otherwise script the page.
const HTML_ESCAPES: Record<string, string> = { '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' };
const escapeHtml = (value: string) => value.replace(/[&<>"']/g, character => HTML_ESCAPES[character]);

export class ListPicker<ModObject, ItemType> extends Input<ModObject, Array<ItemType>> {
readonly config: ListPickerConfig<ModObject, ItemType>;
private readonly itemsDiv: HTMLElement;
Expand Down Expand Up @@ -622,7 +628,7 @@ export class ListPicker<ModObject, ItemType> extends Input<ModObject, Array<Item
`
<p>${this.logLevelDisplayData.get(logLevel)?.header}</p>
<ul>
${validations.map(v => `<li>${v}</li>`).join('')}
${validations.map(v => `<li>${escapeHtml(v)}</li>`).join('')}
</ul>
`;
}
Expand Down
Loading