Round-4 review follow-ups - #16
Merged
Merged
Conversation
… paths - spotify.sh: restore the U+F1BC nerd-font glyph the round-3 rewrite silently dropped (paused/stopped showed a stray leading space). - minimal-bashrc.sh: curl -f everywhere so an HTTP error page can never land as a shell config or an executable git hook. - hooks: the jm.hooks.runRepoHooks switch uses --bool (works on any git) instead of --type=bool (2.18+ only, where the unknown flag made the security switch fail open). Verified 0/no/off/false all skip. - install.sh: materialize_target_dir compares physical paths - with a symlinked checkout path the repo-protection guard silently never engaged. Verified through a symlinked clone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #15: the four survivors from the fourth (regression-focused) adversarial pass, which was cut short by a session limit — 1 confirmed finding plus 3 plausible-but-unverified claims that were cheap to fix regardless. Each fix verified by execution (see commit message).
spotify.shrewritecurl -finminimal-bashrc.shso HTTP error bodies never become configs or executable hooksjm.hooks.runRepoHooksnow honors all git boolean spellings on any git version (--boolvs--type=bool)install.shrepo-symlink protection now engages even when the checkout path itself contains symlinksAlso in this cleanup: PR #14 closed as superseded (its template is byte-identical to master's; its branch was made of the same commits squashed in #15) and its branch deleted.
🤖 Generated with Claude Code