Skip to content

Enable Channel Check Linter#4875

Draft
mdulin2 wants to merge 12 commits into
wormhole-foundation:mainfrom
mdulin2:channel-check-enable
Draft

Enable Channel Check Linter#4875
mdulin2 wants to merge 12 commits into
wormhole-foundation:mainfrom
mdulin2:channel-check-enable

Conversation

@mdulin2

@mdulin2 mdulin2 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This is part two of integrating the channel linter into the repository. Part one added the custom linter flow, and the channel linter; this enables the channel linter.

In general, three types of changes were made:

  • Made the channel non-blocking by using the WriteToChannelWithoutBlocking helper. Done on errC and metric channel writes mostly.
  • Added ctx.Done() to the select for smoother shutdown.
  • Add nolint:channelcheck with an explanation on why the current setup is correct.

It should be noted that msgC is made as an exception to the channelcheck linter because it should always be a blocking write. With the addition of the nolint linter, we can't add nolint:channelcheck with a comment there. So, I left the original Note on channel capacity comment as is.

@socket-security

Copy link
Copy Markdown

Dependency limit exceeded — report not shown.

This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report.

Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard.

Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant