Skip to content

feat: sui wtt pauser#4843

Merged
douglasgalico merged 14 commits into
wormhole-foundation:mainfrom
wormholelabs-xyz:sui_wtt_pauser
Jul 13, 2026
Merged

feat: sui wtt pauser#4843
douglasgalico merged 14 commits into
wormhole-foundation:mainfrom
wormholelabs-xyz:sui_wtt_pauser

Conversation

@douglasgalico

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread sdk/js/src/utils/consts.ts Outdated
Comment thread sui/token_bridge/sources/state.move Outdated
@kcsongor

Copy link
Copy Markdown
Contributor

I think we should consider introducing pauser/unpauser capabilities, and guard the relevant functions behind ownership of these objects. The issue with the current method is that checking tx::sender means the pauser/unpauser can only be an EOA (and not something like the governance program or another smart contract).

Unfortunately it's not possible for the admin to then claw back a capability object from its current holder, so this approach would come with some extra complexity in the form of a table that holds which capability object is the active one (which would look a lot like the current implementation which stores the address of the pauser/unpauser. What I'm proposing would instead store the id of the pauser/unpauser cap objects, and check those instead of tx::sender)

Comment thread sui/token_bridge/sources/governance/set_pauser_addresses.move Outdated
Comment thread sui/token_bridge/sources/state.move Outdated
kcsongor
kcsongor previously approved these changes Jun 1, 2026
kcsongor
kcsongor previously approved these changes Jun 2, 2026
@douglasgalico douglasgalico changed the title feat: sui ntt pauser feat: sui wtt pauser Jun 17, 2026
@douglasgalico
douglasgalico force-pushed the sui_wtt_pauser branch 7 times, most recently from dcdb73d to 98ccef9 Compare June 23, 2026 09:03
@douglasgalico
douglasgalico requested a review from kcsongor June 23, 2026 10:05
mdulin2
mdulin2 previously approved these changes Jun 23, 2026
Comment thread sui/token_bridge/sources/pause.move
Comment thread sui/token_bridge/sources/test/pause_tests.move
@douglasgalico
douglasgalico force-pushed the sui_wtt_pauser branch 3 times, most recently from 4ab0f0b to ff9cd80 Compare July 6, 2026 19:54
Comment thread sui/token_bridge/sources/state.move
@douglasgalico
douglasgalico merged commit 2d8c20d into wormhole-foundation:main Jul 13, 2026
39 of 40 checks passed
@douglasgalico
douglasgalico deleted the sui_wtt_pauser branch July 13, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants