Skip to content

ci: Upgrade golangci-lint version to latest version#4701

Merged
johnsaigle merged 17 commits into
wormhole-foundation:mainfrom
johnsaigle:golangci-upgrade-2.11
Jun 17, 2026
Merged

ci: Upgrade golangci-lint version to latest version#4701
johnsaigle merged 17 commits into
wormhole-foundation:mainfrom
johnsaigle:golangci-upgrade-2.11

Conversation

@johnsaigle

@johnsaigle johnsaigle commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes:

  • channelcheck isn't a configured linter, so this modifies these instances into comments
  • Adds exceptions for what look like attacker-controlled URLs, hard-coded API keys, etc.
  • Fixes variable shadowing
  • Workarounds for context cancellation functions that appeared to not get called (e.g. via defer)

djb15
djb15 previously approved these changes Mar 6, 2026
View reviewed changes
Comment thread node/pkg/notary/admincommands.go
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch 2 times, most recently from 8b8c862 to b3ee177 Compare March 9, 2026 18:36
bemic
bemic reviewed Mar 10, 2026
View reviewed changes
Comment thread node/cmd/guardiand/adminnodes.go
Comment thread node/cmd/ccq/query_server.go
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from bcd3ecb to fe30fe9 Compare March 13, 2026 14:50
@johnsaigle johnsaigle requested a review from bemic March 16, 2026 11:39
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from a77c924 to 53b71fc Compare March 17, 2026 12:35
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from 53b71fc to 5a4bb75 Compare March 24, 2026 15:12
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch 2 times, most recently from 158836b to 606e2ea Compare April 23, 2026 14:21
@johnsaigle johnsaigle requested a review from kcsongor as a code owner April 23, 2026 14:21
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from 606e2ea to 93338c1 Compare May 1, 2026 15:24
This was referenced May 1, 2026
Open
Draft
Merged
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from eb1a786 to 14fe455 Compare May 5, 2026 16:12
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch 3 times, most recently from 1be5187 to 127dca8 Compare May 22, 2026 17:47
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from 127dca8 to 99c4a75 Compare May 28, 2026 19:12
@johnsaigle johnsaigle marked this pull request as draft May 29, 2026 14:50
@johnsaigle johnsaigle dismissed stale reviews from mdulin2 and evan-gray via 522e3e2 June 16, 2026 19:05
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch 2 times, most recently from ca57196 to 97af19f Compare June 17, 2026 11:39
evan-gray
evan-gray previously approved these changes Jun 17, 2026
View reviewed changes
johnsaigle added 17 commits June 17, 2026 11:48
@johnsaigle
ci: Upgrade golangci-lint version to 2.11
ccf2563
@johnsaigle
fix violations
f2747ec
@johnsaigle
normalize channelcheck; explain rootctx
a09beec
@johnsaigle
fix violations
1a03518
@johnsaigle
2.11.1 --> 2.11.3
bc64579
@johnsaigle
fix violations in new pkg
adbc0e9
@johnsaigle
2.11.3 --> 2.11.4
6eabf6e
@johnsaigle
2.12.0
0879837
@johnsaigle
2.12.1
f3ed52c
@johnsaigle
2.12.2
4b2f245
@johnsaigle
update to new install method: https://golangci-lint.run/docs/product/…
cbec385 
…changelog/#v2121
@johnsaigle
fix lints; add unit tests for DER length in xrpl
8387f44
@johnsaigle
replace terra chain ID in test
eb214b1
@johnsaigle
manager bugs + test coverage
b6b0415 
- Resolve truncation issues in the manager implementations by using
hard-coded constants instead of casting values with `byte()`
- Update test coverage
@johnsaigle
skip "known" check where it is dubious
96d65cd
@johnsaigle
revert err change in mockserver
164ea73
@johnsaigle
revert use of method meant only for chain names, not chain IDs
8c4aa0a
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from 97af19f to 8c4aa0a Compare June 17, 2026 15:50
@johnsaigle johnsaigle merged commit df8bc19 into wormhole-foundation:main Jun 17, 2026
65 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djb15 djb15 djb15 approved these changes
@evan-gray evan-gray evan-gray approved these changes
@pleasew8t pleasew8t pleasew8t left review comments
@panoel panoel Awaiting requested review from panoel panoel is a code owner
@fergarrui fergarrui Awaiting requested review from fergarrui
@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner
@bemic bemic Awaiting requested review from bemic bemic is a code owner
@kcsongor kcsongor Awaiting requested review from kcsongor kcsongor is a code owner
@kev1n-peters kev1n-peters Awaiting requested review from kev1n-peters
@mdulin2 mdulin2 Awaiting requested review from mdulin2 mdulin2 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@johnsaigle @pleasew8t @djb15 @mdulin2 @bemic @evan-gray