fix: normalize array framework manifests - #10
Merged
Conversation
qmarcelle
marked this pull request as ready for review
July 20, 2026 13:25
qmarcelle
added a commit
that referenced
this pull request
Jul 20, 2026
* release: bump @workspacejson/codex-mcp to 0.1.7 Stages 0.1.7 across the three sync points (package.json, package-lock, runtime VERSION in src/index.ts). Cut from main so PR #10 (e0827a8, array frameworkManifest normalization) is included -- the prior release branch did not contain it. Normalizer fix only. Extension stays 0.1.2 (separate vsce track). * chore: gitignore local editor state .vscode/ is untracked developer convenience (extension-host launch + build task). It failed check:structure, the first gate in prepublishOnly, blocking local publish. The checker consults git check-ignore plus config/repository-structure.json; .vscodeignore governs vsce bundling only and has no bearing here. Kept separate from the 0.1.7 version bump. * ci(publish): assert the normalizer fix is in the shipped tarball The npm publish workflow asserted tarball contents by filename only, so a release could ship without the array-manifest normalizer and stay green. 0.1.5 and 0.1.6 both did exactly that (HAC-206). Extracts the packed tarball and greps dist/services/workspace.js for normalizeFrameworkManifest. Verified to discriminate: the published 0.1.6 tarball fails this check, a 0.1.7 pack passes it. Scope is deliberately narrow -- this is a presence check on a symbol. It catches the fix going missing, not the fix being wrong. A behavioural gate needs a non-empty frameworkManifest fixture, because an empty array normalizes to undefined with or without the fix and discriminates nothing. That fixture is the follow-up.
qmarcelle
added a commit
that referenced
this pull request
Jul 21, 2026
* release: bump @workspacejson/codex-mcp to 0.1.7 Stages 0.1.7 across the three sync points (package.json, package-lock, runtime VERSION in src/index.ts). Cut from main so PR #10 (e0827a8, array frameworkManifest normalization) is included -- the prior release branch did not contain it. Normalizer fix only. Extension stays 0.1.2 (separate vsce track). * chore: gitignore local editor state .vscode/ is untracked developer convenience (extension-host launch + build task). It failed check:structure, the first gate in prepublishOnly, blocking local publish. The checker consults git check-ignore plus config/repository-structure.json; .vscodeignore governs vsce bundling only and has no bearing here. Kept separate from the 0.1.7 version bump. * ci(publish): assert the normalizer fix is in the shipped tarball The npm publish workflow asserted tarball contents by filename only, so a release could ship without the array-manifest normalizer and stay green. 0.1.5 and 0.1.6 both did exactly that (HAC-206). Extracts the packed tarball and greps dist/services/workspace.js for normalizeFrameworkManifest. Verified to discriminate: the published 0.1.6 tarball fails this check, a 0.1.7 pack passes it. Scope is deliberately narrow -- this is a presence check on a symbol. It catches the fix going missing, not the fix being wrong. A behavioural gate needs a non-empty frameworkManifest fixture, because an empty array normalizes to undefined with or without the fix and discriminates nothing. That fixture is the follow-up. * release: 0.1.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize the producer-emitted array form of
generated.frameworkManifestinto the existing display record while preserving support for legacy object-shaped manifests.Why
Both published 0.1.5 and 0.1.6 packages discard billfold's generated
frameworkManifest: []/ array shape. This loses framework context before the MCP tools can render it.Validation
npm run checkThe regression test now verifies
{ name: "node", version: "22.0.0" }normalizes to{ node: "22.0.0" }.