Fix private-use singleton without a subtag being accepted - #25
Open
spokodev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trailing private-use singleton with no subtags is silently accepted and dropped.
Per RFC 5646,
privateuse = "x" 1*("-" (1*8alphanum)), soxmust be followed by at least one subtag. The dangling-extension-singleton equivalent (en-i) is already rejected with "Found superfluous content after tag", but the private-use branch is not.The entry check only verifies the
xsingleton is present, not that a subtag follows, so the-xis consumed and index advances to the end, leaving no superfluous content to report. Fix: require-+ an alphanumeric afterxbefore entering the private-use section, mirroring the extension entry guard.en-xnow falls through to the existing superfluous-content check, matchingen-i.Adds a regression test. Valid tags (
x-whatever,en-x-a,az-Arab-x-AZE-derbend, …) are unaffected; all existing tests and fixtures pass.