Skip to content

Add check to ensure CHANGELOG.md can be committed - #247

Open
6543 wants to merge 12 commits into
woodpecker-ci:mainfrom
6543-forks:gitignore_savety_check
Open

Add check to ensure CHANGELOG.md can be committed#247
6543 wants to merge 12 commits into
woodpecker-ci:mainfrom
6543-forks:gitignore_savety_check

Conversation

@6543

@6543 6543 commented Nov 28, 2024

Copy link
Copy Markdown
Member

close #242

@6543 6543 added the enhancement Enhance existing feature label Nov 28, 2024
@6543
6543 requested a review from anbraten as a code owner November 28, 2024 16:16
@anbraten anbraten changed the title Add savety check to make sure CHANGELOG.md is able to be commited Add check to ensure CHANGELOG.md can be committed Nov 28, 2024
@anbraten

anbraten commented Dec 8, 2024

Copy link
Copy Markdown
Member

Not sure about this one. If you decided to ignore it, that should be accounted, shouldn't it?

@6543

6543 commented Dec 8, 2024

Copy link
Copy Markdown
Member Author

well or that way around :D

@6543

6543 commented Dec 8, 2024

Copy link
Copy Markdown
Member Author

well with git check-ignore CHANGELOG.md if it returns CHANGELOG.md it is ignored ... now we just have to see how simple git can do that

@6543

6543 commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

Not sure about this one. If you decided to ignore it, that should be accounted, shouldn't it?

Can we create pull requests that have no diff and merge such? (on raw git via shell yes ... but forges do add restrictions

@xoxys

xoxys commented Jan 20, 2025

Copy link
Copy Markdown
Member

Can we create pull requests that have no diff and merge such? (on raw git via shell yes ... but forges do add restrictions

Yes, that's possible, at least in gitea and github. But this would require at least one empty commit.

@6543

6543 commented Jan 11, 2026

Copy link
Copy Markdown
Member Author

@anbraten can we get this check in for now ... if we want to support an version where we dont commit the changelog we can work on that another time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhance existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add savetycheck that generated changelog file is not excludet

3 participants