Fix partial args matching#1300
Open
JUVOJustin wants to merge 5 commits into
Open
Conversation
- Update 'json' mode to use COALESCE(a.extended_args, a.args) for JSON_EXTRACT - Update 'like' mode to check both args and extended_args columns - Add tests for partial_args_matching with short args (≤191 chars) - Add tests for partial_args_matching with long args (>191 chars) Co-authored-by: JUVOJustin <30726576+JUVOJustin@users.noreply.github.com>
Move duplicate JSON support check logic into a private helper method to reduce code duplication in the test file. Co-authored-by: JUVOJustin <30726576+JUVOJustin@users.noreply.github.com>
Ensure global $wpdb is only accessed after the JSON support check to avoid unnecessary global access when test is skipped. Co-authored-by: JUVOJustin <30726576+JUVOJustin@users.noreply.github.com>
Author
|
To be clear: This PR is done by github copilot. I reviewed and tested locally again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial_args_matching(jsonandlikemodes) fails to find actions when arguments exceed 191 characters because it only queries theargscolumn, which contains an MD5 hash for long args while the actual JSON is inextended_args.Changes
jsonmode: UseCOALESCE(a.extended_args, a.args)soJSON_EXTRACToperates on actual JSON datalikemode: Check both columns following the existingsearchquery pattern:((a.extended_args IS NULL AND a.args LIKE %s) OR a.extended_args LIKE %s)Example
Tests
Added test coverage for both
likeandjsonmodes with:args)extended_args)Fix #1299