Fix #89: deterministic pinned tag on release + verify it published to ghcr - #90
Merged
Merged
Conversation
… if pinned tag missing from ghcr (#89)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89 — the
ghcr.iopinned version tag lagging behind GitHub releases (latestwas current at 3.7.1 but the newest pinned tag was 3.6.0).Root cause
The
docker/metadata-actiontype=semvertags only populate when the workflow run's ref is the git tag. On arelease: publishedevent the ref is the tag, so this normally works — but if the release-triggered run failed or never fired, the only run that published anything was thepushtomain, which emits just thelatesttag (and branch tags), never a versioned/pinned tag. That's exactly the observed symptom:latestcurrent, pinned stale.Fix
Compute release version tagstep strips the leadingvfromrelease.tag_name, and atype=raw,value=${{ steps.relver.outputs.version }},enable=${{ github.event_name == 'release' }}entry guarantees the versioned tag is applied on every release regardless of ref parsing.Verify pinned tag is published on registrystep runsdocker buildx imagetools inspectagainst the pinned tag (with a few retries) and fails the release if the tag isn't visible on ghcr — so a silent gap like [Bug]: ghcr.io image outdated (3.6.0) vs latest release (3.7.1) #89 can't recur unnoticed.YAML validated. Note: this prevents recurrence; getting 3.7.1 onto ghcr right now still requires re-running the release publish for
v3.7.1, which I'm handling separately.