feat: granular Firehol level control (ENABLE_FIREHOL_LEVEL1/2/3) - #88
Merged
Merged
Conversation
Add per-level enable flags for Firehol that fall back to the master ENABLE_FIREHOL when unset, so existing configs are unchanged. Fixes the gap where ENABLE_FIREHOL was all-or-nothing for all 3 levels. Closes #83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #83. Previously
ENABLE_FIREHOLwas an all-or-nothing switch for all three Firehol levels. This adds per-level control:ENABLE_FIREHOL_LEVEL1,ENABLE_FIREHOL_LEVEL2,ENABLE_FIREHOL_LEVEL3ENABLE_FIREHOLwhen unset, so existing configs behave identically.Example: enable only level1
Implementation
BlocklistSourcenow uses its ownenabled_key(enable_firehol_level1/2/3).Config.from_env()computes each level fromENABLE_FIREHOL_LEVELnif present, else from the masterENABLE_FIREHOL..env.exampleand the--helptext updated;VALID_ENABLE_VARSpicks up the new keys automatically.Verification
Backward compatible — no behavior change for users who only set
ENABLE_FIREHOL.