Skip to content

Fix for pip 19.3.1 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgarnica wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for pip 19.3.1 #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion libpip2pi/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ def try_int(x):


if pip_version:
if pip_version >= (10, 0, 0):
if pip_version >= (19, 3, 1):
from pip._internal.main import main as pip_main

@tikank tikank Dec 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, that as pip user guide suggests to use pip program and the pip program is defined in entry points in setup.py, would getting that entry point to be a version independent way to find main function. Could something like this work:

Suggested change
from pip._internal.main import main as pip_main
pip_main = pkg_resources.load_entry_point('pip', 'console_scripts', 'pip')

pip_download_command = 'download --dest'
pip_no_binary_command = '--no-binary=:all:'
elif pip_version >= (10, 0, 0):
from pip._internal import main as pip_main
pip_download_command = 'download --dest'
pip_no_binary_command = '--no-binary=:all:'
Expand Down