Feat/first challenge#77
Open
alain-chevanier wants to merge 28 commits into
Open
Conversation
bgilm
reviewed
Jul 11, 2018
|
|
||
| const AppRouting = () => ( | ||
| <Router> | ||
| <Switch> |
bgilm
reviewed
Jul 11, 2018
| <Switch> | ||
| <Route path="/trending" component={Trending} /> | ||
| <Route path="/favorite" component={Favorite} /> | ||
| <Redirect to="/trending" /> |
There was a problem hiding this comment.
It would be nice to send an object to let the user know what happened with that not found route.
added 13 commits
July 11, 2018 16:43
…IPHY - NEW SAGA DEFINED TO FETCH DATA ON SEARCH - NEW ACTION DEFINED TO FETCH DATA FROM API ON SEARCH - TRENDING COMPONENT SEPARATED TO HANDLE CONCERN OF REDUX BINDING IN A SEPARETE COMPONENT
…NOW WAS SEPARATE ACCORDING TO CONCERNS
- ALSO ADDING TESTS FOR ON CLICK EVENT HANDLERS
timgivois
reviewed
Jul 12, 2018
| const NavBarElement = styled(Link)` | ||
| float: left; | ||
| color: ${props => (props.active ? 'white' : '#f2f2f2')}; | ||
| background-color: ${props => (props.active ? '#4CAF50' : 'inherit')}; |
timgivois
reviewed
Jul 12, 2018
|
|
||
| import React from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
| import './index.css'; |
timgivois
reviewed
Jul 12, 2018
| text-align: center; | ||
| } | ||
|
|
||
| .c2 { |
added 7 commits
July 12, 2018 16:11
- FAVORITE GIFS - FILTER TEXT - TRENDING GIFS
added 3 commits
July 12, 2018 18:44
- INTEGRATION FILES LIKE INDEX.JS - STORE DEFINITION - SAGAS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First Challenge solution.