Challenge#74
Open
gabrielgs wants to merge 32 commits into
Open
Conversation
timgivois
reviewed
Jul 10, 2018
| } | ||
| } | ||
|
|
||
| componentDidMount() { |
There was a problem hiding this comment.
you should do this with sagas not with state. Remember that you are required to create almost stateless components.
timgivois
reviewed
Jul 10, 2018
| }) | ||
|
|
||
| console.log(newFavoriteGif) | ||
| localStorage.setItem('favoriteGif', JSON.stringify(newFavoriteGif)) |
There was a problem hiding this comment.
you shouldn't be saving to local storage in the component, that's a sagas job
timgivois
reviewed
Jul 10, 2018
| this.fetchTrending() | ||
| } else { | ||
| axios.get( | ||
| `https://api.giphy.com/v1/gifs/search?api_key=mjA6Ro3NCh6Q8yWu2qyxlIksx3ACBbAJ&q=${query}&limit=25&offset=0&rating=G&lang=en` |
timgivois
reviewed
Jul 10, 2018
|
|
||
| import axios from 'axios' | ||
|
|
||
| class Home extends Component { |
timgivois
reviewed
Jul 11, 2018
| @@ -0,0 +1,33 @@ | |||
| .GifContainer { | |||
timgivois
reviewed
Jul 11, 2018
|
|
||
| const GifCard = ({gif, addFavorites}) => { | ||
| return ( | ||
| <article className="GifCard"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.