Challenge (Diego Plascencia)#72
Open
diego-d5000 wants to merge 25 commits into
Open
Conversation
diego-d5000
changed the title
…story deletion necessary), add api keys to env and add env example
timgivois
reviewed
Jul 10, 2018
| @@ -0,0 +1 @@ | |||
| REACT_APP_GIPHY_API_KEY=OWyGqcD3SWfggMMzdErRe9yHvasf2BBq No newline at end of file | |||
There was a problem hiding this comment.
you shouldn't save the api key in the .env.example
Author
There was a problem hiding this comment.
It's ok, it's just an example, It's a fake key haha
timgivois
reviewed
Jul 10, 2018
| const filteredGifs = this.getFilteredGifs(gifs); | ||
| return ( | ||
| <Fragment> | ||
| <NavBar onSearch={(search) => this.setState({ favoritesSearch: search })} /> |
timgivois
reviewed
Jul 10, 2018
| @@ -0,0 +1,88 @@ | |||
| import { Row } from './Grid.styled'; | |||
| import styled from 'styled-components'; | |||
There was a problem hiding this comment.
Nice I liked the styled components :)
timgivois
reviewed
Jul 10, 2018
| @@ -0,0 +1,42 @@ | |||
| import styled from 'styled-components'; | |||
|
|
|||
| const breakXs = '480px'; | |||
timgivois
reviewed
Jul 10, 2018
| padding: 0; | ||
| font-family: sans-serif; | ||
| } | ||
| background-color: #fafafa; |
Author
There was a problem hiding this comment.
Ok. I missed the option of use injectGlobal, but with your talk yesteday now I know how to solve this and use styled components instead of this css.
Very nice talk, thank you 😃 .
bgilm
reviewed
Jul 12, 2018
| const { gifs } = this.props; | ||
| const filteredGifs = this.getFilteredGifs(gifs); | ||
| return ( | ||
| <Fragment> |
Robfz
reviewed
Jul 12, 2018
| const RECEIVE_NEXT_PAGE_TRENDING_GIFS = 'RECEIVE_NEXT_PAGE_TRENDING_GIFS'; | ||
|
|
||
| const { fetchTrendingGifs, receiveTrendingGifs, receiveNextPageTrendingGifs } = createActions({ | ||
| [FETCH_TRENDING_GIFS]: (search = '', page = 0) => ({ search, page }), |
| } | ||
|
|
||
| getFilteredGifs = (gifs) => { | ||
| const { favoritesSearch } = this.state; |
Contributor
There was a problem hiding this comment.
This logic could be moved to the Redux store.
| } | ||
|
|
||
| handleLoadMoreData = () => { | ||
| this.setState((prevState, props) => { |
Contributor
There was a problem hiding this comment.
Functional state + setState callback, nice 👍
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| search: '', |
Contributor
There was a problem hiding this comment.
This search term could be reused with the other view and stored in the Redux store.
| class NavBar extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| this.state = { search: '' } |
Contributor
There was a problem hiding this comment.
Same thing about the search.
| @@ -0,0 +1,23 @@ | |||
| import { handleActions } from 'redux-actions'; | |||
| const PAGE_SIZE = 20; | ||
|
|
||
| // taken from: | ||
| // https://stackoverflow.com/questions/6566456/how-to-serialize-an-object-into-a-list-of-url-query-parameters |
Contributor
There was a problem hiding this comment.
Giving other devs credit is a great practice, keep it up!
| import loggerMiddleware from './middleware/logger'; | ||
| import rootReducer from './reducers'; | ||
| import rootSaga from './sagas'; | ||
| import persistState from 'redux-localstorage'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for complete the 'React Series Challenge' for React Course at Wizeline Academy CDMX (Diego Plascencia)