Challenge First Delivery#67
Open
rosendosalazarbta wants to merge 13 commits into
Open
Conversation
timgivois
reviewed
Jul 11, 2018
| @@ -0,0 +1,62 @@ | |||
| .app .navbar { | |||
There was a problem hiding this comment.
you shouldn't need this as you'll use styled components. Delete it and create components
Author
There was a problem hiding this comment.
Thank you for you feedback.
timgivois
reviewed
Jul 11, 2018
| </p> | ||
| </div> | ||
| <Provider store={_store}> | ||
| <div className="app"> |
There was a problem hiding this comment.
styled components to this whole file
Author
There was a problem hiding this comment.
It is already corrected
added 2 commits
July 11, 2018 18:20
timgivois
reviewed
Jul 12, 2018
| import styled from 'styled-components'; | ||
|
|
||
| export const ContentGif = styled.div` | ||
| background-color: ${props => props.favorite ? '#b5c4de' : '#edf0f5'}; |
timgivois
reviewed
Jul 12, 2018
| "devDependencies": { | ||
| "enzyme": "^3.3.0", | ||
| "enzyme-adapter-react-16": "^1.1.1", | ||
| "jest": "^23.4.0", |
timgivois
reviewed
Jul 12, 2018
| "private": true, | ||
| "dependencies": { | ||
| "axios": "^0.18.0", | ||
| "jest-cli": "^23.4.0", |
bgilm
reviewed
Jul 12, 2018
| </Navbar> | ||
| <AppBody> | ||
| <ErrorBoundary> | ||
| <Switch> |
bgilm
reviewed
Jul 12, 2018
| <Switch> | ||
| <Route path="/Home" component={ComponentHome} /> | ||
| <Route path="/Favorites" component={ComponentFavorites} /> | ||
| <Redirect to={{ pathname: "/Home", }} /> |
There was a problem hiding this comment.
it would be nice to provide context on the redirect to the user
bgilm
reviewed
Jul 12, 2018
| list-style: none; | ||
| `; | ||
|
|
||
| export const NavbarLink = styled(Link)` |
bgilm
reviewed
Jul 12, 2018
| this.props.dispatch(updateTextFilter(e.target.value)); | ||
| }} /> | ||
| </ContainerInputText> | ||
| <Fragment> |
Robfz
reviewed
Jul 12, 2018
| @@ -0,0 +1,5 @@ | |||
| import * as types from '../constants/actionTypes'; | |||
|
|
|||
| export const addGifToFavorites = (gif) => ({ type: types.GIF_FAVORITE_ADD, gif, }); | |||
Contributor
There was a problem hiding this comment.
The related data of an action should be contained in a payload attribute.
| const favorites = [...newState.favorites]; | ||
| if (!favorites.find(x => x.id == gif.id)) favorites.push(gif); | ||
| newState.favorites = favorites; | ||
| getLocalStorage().setItem('favorites', JSON.stringify(newState.favorites)); |
Contributor
There was a problem hiding this comment.
Here you are calling localStorage, this is a side effect, something that we should avoid in the reducers. You can achieve this feature using middleware, sagas or a subscription to the store.
| export function* gifsTrending() { | ||
| try { | ||
| const gifs = yield call(fetchGifsTrending); | ||
| yield put({ type: types.GIFS_TRENDING_GET, gifs }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First delivery for revision.