Challenge Started.#61
Open
charlybanya wants to merge 13 commits into
Open
Conversation
-- Reducers and actions created to manage state of GifList and SearchBar -- Placeholder routes added to the project -- First saga added to retrieve Giphy API data -- Test strings added as components placeholder
-- Functionality to add or remove gifs from favorites, completed with actions, reducers and sagas -- Display favorite gifs view, Added, still need a way to update the content after a gif is removed from favorites -- GifElement component, Added
…ons, reducers and sagas
-- GifElement component, refactored
…ch of favorites -- Search into favorites, Completed with actions and reducers
-- SearchBars unified. -- FavSearchBar deleted from components, reducers and actions. -- NavBar styled
timgivois
reviewed
Jul 11, 2018
| render() { | ||
| return ( | ||
| <Provider store={store}> | ||
| <div className='App'> |
There was a problem hiding this comment.
you can create a styled component here
timgivois
reviewed
Jul 11, 2018
| font-size: 17px; | ||
| `; | ||
|
|
||
| injectGlobal` |
There was a problem hiding this comment.
create another file that's called global.style.js and then import it in App.js
Author
There was a problem hiding this comment.
Thanks for the feedback.
I'll do it, right now!
added 2 commits
July 11, 2018 17:50
-- App reformat for testing purposes. -- Working on Component testing
-- Working on Component Testing
bgilm
reviewed
Jul 12, 2018
| <Switch> | ||
| <Route path='/home' component={Home} /> | ||
| <Route path='/favorites' component={Favorites} /> | ||
| <Redirect to={{ |
bgilm
reviewed
Jul 12, 2018
| <HeadLink to='/favorites' activeClassName='active'>Favorites</HeadLink> | ||
| </NavBar> | ||
| </header> | ||
| <Switch> |
bgilm
reviewed
Jul 12, 2018
| overflow: hidden; | ||
| `; | ||
|
|
||
| export const HeadLink = styled(NavLink)` |
bgilm
reviewed
Jul 12, 2018
| const Favorites = (props) => { | ||
| const { favoritedGifs } = props; | ||
| return ( | ||
| <Fragment> |
Robfz
reviewed
Jul 12, 2018
Robfz
left a comment
Robfz
left a comment
Contributor
There was a problem hiding this comment.
Great job! Only thing missing was the persistence of the favorites.
|
|
||
| test('should call "fetchApi" function to get trending gifs', () => { | ||
| const firstYield = generatorGetTrendingGifs.next().value; | ||
| expect(firstYield).toEqual(call(fetchApi, trendingResource)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.