1st delivery (Eliahu Cabasso)#54
Open
EC-AI wants to merge 19 commits into
Open
Conversation
…ng back the search text didn't appear on the input
bgilm
reviewed
Jul 9, 2018
| constructor(props){ | ||
| super(props); | ||
| this.state = { | ||
| hasError: false |
There was a problem hiding this comment.
It is nice to have an info var to store the errorInfo
bgilm
reviewed
Jul 9, 2018
| } | ||
|
|
||
| componentDidCatch() { | ||
| this.setState(() => ({hasError: true})); |
bgilm
reviewed
Jul 9, 2018
|
|
||
| class ExplorePanel extends Component { | ||
|
|
||
| componentDidMount() { |
bgilm
reviewed
Jul 9, 2018
| return ( | ||
| <div> | ||
| <SearchBar /> | ||
| <ErrorBoundary message="Unable to load."> |
There was a problem hiding this comment.
The message attribute value Unable to load may have not the most accurate content as this component will show on the tree despite having an error thrown or not.
bgilm
reviewed
Jul 9, 2018
| import Star from './Star'; | ||
|
|
||
| const GifView = ({ src, id, favorite, gif }) => ( | ||
| <div style={{display: 'inline-block', padding: 10}} className="GifView"> |
bgilm
reviewed
Jul 9, 2018
| <Switch> | ||
| <Route path="/explore" component={ExplorePanel} /> | ||
| <Route path="/favorites" component={FavoritesPanel} /> | ||
| <Redirect to="/explore" /> |
There was a problem hiding this comment.
It is a nice feature to send an object to handle the redirect and let the user know what happened before the redirect.
bgilm
reviewed
Jul 9, 2018
| @@ -0,0 +1,5 @@ | |||
| export default { | |||
| API_KEY: 'pL67xABMUz8kJ7kAF9LIomqHGMueUK56', | |||
There was a problem hiding this comment.
Use an .env file to store your API key and dont version that file. You can provide an .ev.example file to express the usage of that value.
bgilm
reviewed
Jul 11, 2018
|
|
||
| const NavBar = (props) => ( | ||
| <StyledNavBar> | ||
| <StyledNavLink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st delivery