Skip to content

Author added by Emmanuel Pacheco Yupit#52

Open
EmmYup wants to merge 34 commits into
wizelineacademy:masterfrom
EmmYup:master
Open

Author added by Emmanuel Pacheco Yupit#52
EmmYup wants to merge 34 commits into
wizelineacademy:masterfrom
EmmYup:master

Conversation

@EmmYup

@EmmYup EmmYup commented Jul 6, 2018

Copy link
Copy Markdown

No description provided.

Comment thread src/App.js Outdated
import { injectGlobal } from 'styled-components';
import { Wrap } from './App.style';

injectGlobal`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a global file for this

Comment thread src/index.js Outdated
import ReactDOM from 'react-dom';
import { Provider } from 'react-redux';
import store from './store';
import './index.css';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use css

import ItemsList from './index';
import store from '../../store';

describe('test ItemsList Render', () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test the components too please

Comment thread src/App.js
<Fragment>
<Navbar />
<Wrap>
<Switch>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timgivois

Copy link
Copy Markdown

delete the console logs of the test output

Comment thread src/App.js
</p>
</div>
<Router>
<Fragment>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants