first commit, basic pages and routes#50
Open
a13xmh wants to merge 10 commits into
Open
Conversation
added 8 commits
July 6, 2018 01:21
timgivois
reviewed
Jul 11, 2018
|
|
||
| if (isFav) { | ||
| return ( | ||
| <StyledImg> |
There was a problem hiding this comment.
If you create a StyledImg that receives a isFav prop tthen 💯
timgivois
reviewed
Jul 11, 2018
| import styled from "styled-components"; | ||
| import { Link } from "react-router-dom"; | ||
|
|
||
| const StyledMenu = styled.div` |
There was a problem hiding this comment.
I don't really like the approach of creating wrapper divs and inside css selectors of everything. Create little components :)
added 2 commits
July 11, 2018 22:06
|
I'm getting an error while running tests: |
|
pluse delete your yarn lock and generate it again |
|
you could have ignore index at src with that you'd have 70%. but, it's very close don't worry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR from alejandro martinez