Skip to content

first commit, basic pages and routes#50

Open
a13xmh wants to merge 10 commits into
wizelineacademy:masterfrom
a13xmh:first_delivery
Open

first commit, basic pages and routes#50
a13xmh wants to merge 10 commits into
wizelineacademy:masterfrom
a13xmh:first_delivery

Conversation

@a13xmh

@a13xmh a13xmh commented Jul 6, 2018

Copy link
Copy Markdown

PR from alejandro martinez


if (isFav) {
return (
<StyledImg>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you create a StyledImg that receives a isFav prop tthen 💯

import styled from "styled-components";
import { Link } from "react-router-dom";

const StyledMenu = styled.div`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the approach of creating wrapper divs and inside css selectors of everything. Create little components :)

@timgivois

Copy link
Copy Markdown

I'm getting an error while running tests:

  ● sagaTrendingGetDataRequest test › Should get trending gifs

    expect(received).toEqual(expected)

    Expected value to equal:
      {"@@redux-saga/IO": true, "CALL": {"args": Array [], "context": null, "fn": [Function getTrendingDataRequest]}}
    Received:
      undefined

    Difference:
Comparing two different types of values. Expected object but received undefined.

@timgivois

Copy link
Copy Markdown

pluse delete your yarn lock and generate it again

@timgivois

Copy link
Copy Markdown

you could have ignore index at src with that you'd have 70%. but, it's very close don't worry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants