Vue unidriver - #197
Open
AlexDubok wants to merge 4 commits into
Open
Conversation
Contributor
|
Very cool @AlexDubok, awesome to see ex-Wixers taking the Unidriver spirit with them :D PS: I'm not longer employed by Wix but still a big believer in Unidriver. Have lost review/write access to this repo :/ @nitayneeman / @Tokyros can you help me regain some access here? or help pushing this PR forward? |
GabiGrin
reviewed
Jan 18, 2023
Co-authored-by: Gabriel Grinberg <gabi.grinberg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! First of all, thank you for maintaining this awesome project! 😍
As Vue developer at the moment, I want it to be part of this unidriver party 🎉
Please, accept it under your roof 🏡
On the implementation: I made
@vue-test-utils'sWrapperas "native" element for unidriver because Vue unit tests heavily rely on it (emitting events from components, changing reactive data, etc.)