[puppeteer adapter] Move @types/puppeter to devDependencies - #186
Open
mykas wants to merge 3 commits into
Open
Conversation
amitdahan
approved these changes
Jul 20, 2022
amitdahan
left a comment
amitdahan
left a comment
There was a problem hiding this comment.
LGTM!
I feel there might be a slight chance that users without any @types/puppeteer-core in their node_modules and somehow still using this adapter might break, but I'm not even sure they would break with skipLibCheck turned to true so let's do this and help if this somehow breaks
|
@mykas 馃憢 |
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some of the Wix infrastructure moved to puppeteer major version 14 - consumers started to get the type build failures on types mismatches. This adapter is cross major version compatible and should work fine with puppeteer 14 as there are no actual breaking changes for api that this adapter is using.
The short term solution is to move
@types/puppeteer-coreto devDeps and unblock users from getting red builds.The long term solution will be to upgrade this adapter to latest puppeteer and support backwards compatible api as long as possible.