Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/triage/workflow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,9 @@ export class TriageWorkflow extends WorkflowEntrypoint<
await this.retriage(step, client, credentials, params, routed),
);
case 'verify-fix':
return finish(await this.verifyFix(step, client, params, routed));
return finish(
await this.verifyFix(step, client, credentials, params, routed),
);
}
}

Expand Down Expand Up @@ -1328,6 +1330,7 @@ export class TriageWorkflow extends WorkflowEntrypoint<
private async verifyFix(
step: WorkflowStep,
client: () => Promise<InstallationClient>,
credentials: GitHubCredentials,
params: TriageWorkflowParams,
routed: RoutedIssue,
): Promise<TriageWorkflowOutcome> {
Expand Down Expand Up @@ -1426,8 +1429,25 @@ export class TriageWorkflow extends WorkflowEntrypoint<
triage.labels.fixPending,
triage.labels.fixRejected,
);
await postIssueComment(
api,
params.owner,
params.repo,
params.issueNumber,
`The candidate fix was rejected: ${verdict.reasoning}\n\nRe-evaluating whether the feedback warrants a new triage attempt.`,
);
});

// The comment that rejected the fix already carries whatever new,
// actionable information prompted the rejection — most often a
// concrete regression and a suggested fix, as here. Don't park the
// issue waiting on a second human comment to notice: feed the same
// conversation straight into the retriage judge now that the label
// reflects the rejection.
return this.retriage(step, client, credentials, params, {
...routed,
issue: { ...issue, currentLabel: triage.labels.fixRejected },
});
return { outcome: 'fix-rejected' };
}

const pullRequest = await step.do(
Expand Down
Loading