feat(ito): reset core workflow and release authority - #254
Merged
Conversation
# Conflicts: # ito-rs/crates/ito-cli/src/app/run.rs # ito-rs/crates/ito-cli/src/runtime.rs
# Conflicts: # docs/config.md # ito-rs/crates/ito-cli/src/runtime.rs # ito-rs/crates/ito-core/src/coordination.rs
# Conflicts: # ito-rs/crates/ito-config/src/config/types.rs # ito-rs/crates/ito-core/src/distribution.rs
# Conflicts: # .brv/context-tree/_manifest.json # CHANGELOG.md # ito-rs/crates/ito-cli/CHANGELOG.md # ito-rs/crates/ito-cli/src/app/instructions.rs # ito-rs/crates/ito-cli/tests/init_obsolete_cleanup.rs # ito-rs/crates/ito-core/CHANGELOG.md # ito-rs/crates/ito-core/tests/distribution.rs # ito-rs/crates/ito-templates/CHANGELOG.md # ito-rs/crates/ito-templates/assets/skills/ito-apply/SKILL.md # ito-rs/crates/ito-templates/assets/skills/ito-loop/SKILL.md # ito-rs/crates/ito-templates/assets/skills/ito-proposal/SKILL.md # ito-rs/crates/ito-templates/assets/skills/ito-update-repo/SKILL.md # ito-rs/crates/ito-templates/assets/skills/ito-using-git-worktrees/SKILL.md # ito-rs/crates/ito-templates/src/lib_tests.rs # ito-rs/crates/ito-templates/tests/worktree_template_rendering.rs # source-guide.json
# Conflicts: # .brv/context-tree/_manifest.json # ito-rs/crates/ito-cli/codemap.md # ito-rs/crates/ito-cli/src/app/init.rs # ito-rs/crates/ito-cli/src/app/manifesto_instructions.rs # ito-rs/crates/ito-cli/src/cli.rs # ito-rs/crates/ito-cli/src/cli_tests.rs # ito-rs/crates/ito-cli/src/commands/tasks.rs # ito-rs/crates/ito-cli/tests/snapshots/cli_snapshots__ito_help_all.snap # ito-rs/crates/ito-cli/tests/snapshots/cli_snapshots__ito_help_subcommand_all.snap # ito-rs/crates/ito-cli/tests/snapshots/cli_snapshots__ito_init_help.snap # ito-rs/crates/ito-core/codemap.md
Contributor
|
Important Review skippedToo many files! This PR contains 2767 files, which is 2617 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (2767)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
|
Contributor
|
LGTM ✅ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request consolidates and updates the repository's Ito skills and workflows, transitioning from legacy coordination storage to tracked main-branch authority, while removing obsolete specialist agent assets and skills. The feedback highlights a critical issue in the ito-apply skill files across multiple harnesses (.claude, .codex, and .github), where the use of || exit 1 in interactive commands could prematurely terminate the agent's active shell session. It is recommended to chain these commands with && to ensure safe, sequential execution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
|
LGTM ✅ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| mkdir -p "../ito-worktrees" | ||
| WORKTRUNK_WORKTREE_PATH="$(ito path worktrees-root)/{{ branch | sanitize }}" wt switch --create <full-change-id> --base main | ||
| CHANGE_DIR=$(ito worktree ensure --change "<full-change-id>") || exit 1 | ||
| cd "$CHANGE_DIR" |
Contributor
There was a problem hiding this comment.
Issue: Root AGENTS.md still uses || exit 1, killing the interactive shell on preflight failure
Why: Commit d6e4941 (this PR's latest commit, "fix(ito-apply): preserve interactive shell on preflight failure") fixed this exact pattern in .claude/skills/ito-apply/SKILL.md, .codex/..., .github/..., .opencode/..., .pi/..., and the ito-templates source assets (project AGENTS.md + worktrees.md.j2), but the repo's own root AGENTS.md — the file agents actually load for this repository — was not updated and still contains || exit 1. Since AGENTS.md is a rendered copy of ito-rs/crates/ito-templates/assets/default/project/AGENTS.md (identical apart from filled-in template vars), it should have received the same fix. As written, any agent following this file will still have its shell/session killed if ito worktree ensure fails here, i.e. the exact bug this commit set out to fix is still live in the repo's primary instructions.
Fix: Apply the same change here:
CHANGE_DIR=$(ito worktree ensure --change "<full-change-id>") && \
cd "$CHANGE_DIR" && \
ito change preflight "<full-change-id>" --for execute
Contributor
|
LGTM ✅ |
Automated fixes applied by CI: - Line endings (CRLF -> LF) - Trailing whitespace - Final newlines - JSON formatting - Rust formatting (cargo fmt) - Regenerated config schema (schemas/ito-config.schema.json)
Contributor
|
LGTM ✅ |
Contributor
|
LGTM ✅ |
Contributor
|
LGTM ✅ |
Contributor
|
LGTM ✅ |
Contributor
|
LGTM ✅ |
Contributor
|
LGTM ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ito's workflow and release surfaces had accumulated competing sources of authority, coordination-only assumptions, and legacy integrations that made the standard path harder to review and ship safely. This cutover makes reviewed state on
mainauthoritative while keeping experimental capabilities explicit and independently gated.What Changed
mainthe readiness boundary for apply and implementation.itocontent and retiredocs/itoito-clipackage and 16 cargo-dist artifactsBehavioral Evidence
ito-clirelease with 16 artifactsDetailed evidence:
.ito/changes/031-06_migrate-ito-authority-and-release/evidence/release-verification.md.ito/changes/031-06_migrate-ito-authority-and-release/requirement-audit.md