[turborvb] 新規パッケージ追加(#155 候補: 第一原理 QMC ソルバー) - #199
Open
k-yoshimi wants to merge 2 commits into
Open
Conversation
Add apps/turborvb for TurboRVB v1.0.0, following the mvmc/tenes CMake app template. Build specifics: - out-of-source CMake build (>=3.20) with the default options (EXT_SERIAL=ON, EXT_PARALLEL=ON, QMC + DFT + tools); auto-detects the Fortran/C compiler and BLAS/LAPACK (Intel MKL when available), finds MPI with find_package(MPI) and links ScaLAPACK when found - captures CC/FC/CMAKE/MA_EXTRA_FLAGS/MAKE_J via config.txt; the full build requires an MPI Fortran compiler for the parallel executables - installs the QMC engine (turborvb-serial.x, turborvb-mpi.x), DFT prep (prep-serial.x, prep-mpi.x) and tools (makefort10.x, readalles.x, ...) - turborvbvars.sh exports TURBORVB_ROOT (the root variable name), which the turbogenius wrapper reads at import time; README documents the pairing - smoke test asserts the core executables were installed - CI: add to the app matrix with a per-app override (MAKE_J=-j4); register in the en/ja Sphinx appendix Note: ohtaka is in scheduled maintenance until 2026-07-14; CI (ubuntu, gfortran + openmpi + lapack/scalapack) validates the clean-room build now, and the ohtaka Intel-oneAPI compute-node run will be added after maintenance. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QaWKJsSQqCakkMEKZpJcvP
- install.sh: export CC/FC in config.txt instead of the tenes-inherited CXX (TurboRVB is Fortran+C; this restores the compiler-override contract) - test.sh: split the executable check so serial binaries are always required and a missing turborvb-mpi.x gives an explicit "MPI not found" diagnostic (the full default build requires MPI, so it stays a hard failure) - README: drop the fragile ../turbogenius relative link (plain text instead) and use US spelling Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QaWKJsSQqCakkMEKZpJcvP
Collaborator
Author
AI レビューサイクル結果(Codex + Antigravity)CI(クリーンルーム・ビルド検証)ubuntu-24.04 / ubuntu-22.04 の両 Phase 1 — Codex(コード correctness)
Phase 2 — Antigravity(ドキュメント / ワークフロー)
検証方針ohtaka は 2026-07-14 09:00 まで保守中のため、本 PR は CI(ubuntu クリーンルーム)で検証済み。保守明けに ohtaka の Intel oneAPI + Codex の must_fix・Antigravity の must_fix_docs はいずれも対応済み(残指摘も理由付きで対応)。CI 再実行の結果を確認のうえ収束とします。 |
k-yoshimi
added a commit
that referenced
this pull request
Jul 9, 2026
…inaries Holistic cross-PR review (turbogenius #198 vs turborvb #199) flagged that turbogeniusvars.sh defaulted TURBORVB_ROOT to the bare $MA_ROOT/turborvb parent, so sourcing turbogeniusvars.sh alone let `import turbogenius` succeed but deferred a confusing failure to QMC run time (the real binaries live in the versioned $MA_ROOT/turborvb/turborvb-<ver>-<rev> that turborvbvars.sh exports). Resolve TURBORVB_ROOT in order: existing value -> the installed turborvb package's turborvbvars.sh (auto-sourced, gives the versioned path with the binaries) -> bare $MA_ROOT/turborvb (import-only fallback). Installing the turborvb package first is now sufficient; no source-ordering to remember. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QaWKJsSQqCakkMEKZpJcvP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
#155(2024年度追加候補)の TurboRVB(第一原理量子モンテカルロ・ソルバー, v1.0.0)を新規パッケージとして追加します。mvmc / tenes と同じ CMake アプリのテンプレートに従っています。TurboGenius(#198)が必要とする本体です。
ビルド構成(serial + MPI フル)
EXT_SERIAL=ON,EXT_PARALLEL=ON、QMC + DFT + tools)。find_package(MPI)で検出し、無ければ CMake が並列版を自動的に外す。ScaLAPACK は見つかればリンク。CC/FC/CMAKE/MA_EXTRA_FLAGS/MAKE_Jを config.txt で受け取る。フルビルドには MPI Fortran コンパイラが必要。turborvb-serial.x/turborvb-mpi.x、DFT prepprep-serial.x/prep-mpi.x、ツールmakefort10.x/readalles.xなど。TurboGenius 連携
turborvbvars.shは(root 変数名がそのまま)TURBORVB_ROOTを export します。TurboGenius(#198)は import 時にTURBORVB_ROOTを参照するため、turbogeniusvars.shより先にturborvbvars.shを source すれば TurboGenius がこの TurboRVB を利用します。v1.0.0 は一部ツールを-serial付きで命名するため、必要に応じTURBO*_RUN_COMMANDで上書き可能(README に明記)。検証方針(重要)
ohtaka は 2026-07-14 09:00 まで保守期間中(全計算ノードが予約
202607.Mで確保)で、計算ノードでの実機ビルドは保守明けに実施予定です。それまでは GitHub Actions(ubuntu, gfortran + openmpi + lapack/scalapack)でクリーンルーム・ビルド検証を回します(本 PR の CI)。CI が通ることを確認後、ohtaka の Intel oneAPI +i8cpu(インタラクティブ)での実機ビルドを追記します。.github/scripts/turborvb.sh(MAKE_J=-j4)を追加。app/2919/ jaapp/2786、GPLv3)。🤖 Generated with Claude Code