[cryspy] 新規パッケージ追加(#155 候補: 結晶構造探索, ohtaka 検証済み) - #197
Open
k-yoshimi wants to merge 2 commits into
Open
Conversation
CrySPY 1.4.3 (crystal structure prediction), installed with pip into the MateriApps prefix, following the physbo Python-app pattern (PYTHONPATH-aware vars file). install.sh pins numpy<2 and pandas<2.2 in one resolution pass so the whole stack stays on the NumPy 1.x ABI that compiled deps like pyshtools ship wheels for; otherwise the cryspy command aborts at import with a NumPy 1.x/2.x ABI error. README/README_ja note the Python 3.9-3.12 requirement (pyshtools wheels) and the numpy/pandas pins. Verified end-to-end on ISSP ohtaka with Python 3.9: the installer flow (setup -> install -> link -> runtest) passes; runtest confirms `import cryspy` and that the `cryspy` command starts (Start CrySPY 1.4.3). Refs #155 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ard) - add cryspy to the GitHub Actions app matrix so it is built/tested in CI - register cryspy in the en/ja Sphinx appendix (toctree + README stub) - test.sh: guard the startup smoke test with a timeout (fails on 124) instead of masking every nonzero exit, keeping the expected no-input early exit tolerated and the banner assertion intact Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QaWKJsSQqCakkMEKZpJcvP
Collaborator
Author
AI レビューサイクル結果(Codex + Antigravity)本 PR に対して ai-review-cycle(Phase 1: Codex / Phase 2: Antigravity)を実施しました。 Phase 1 — Codex(コード correctness)
Phase 2 — Antigravity(ドキュメント / ワークフロー)
動作確認物性研 ohtaka(Python 3.9)で setup → install → link → runtest を実機確認済み: Codex の must_fix・Antigravity の must_fix_docs はいずれも無く、指摘は上記のとおり対応済みのため収束と判断します。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Refs #155(2024年度追加候補の1つ)
CrySPY 1.4.3(結晶構造探索, Python)を
apps/cryspyとして追加します。pip ベースなので既存のphysbo/py2dmatと同じパターン(PYTHONPATH 対応の vars 生成)に乗せています。構成
archive/refs/tags/v1.4.3.tar.gz)を取得し、pip install ./で prefix へ導入install.shはnumpy<2とpandas<2.2を同一解決パスで固定。CrySPY は pyshtools 等のコンパイル済み依存を牽引し、それらは NumPy 1.x 向け wheel を配布するため、固定しないと NumPy 1.x/2.x の wheel が混在しcryspyコマンドが import 時に ABI エラー(Cannot convert numpy.ndarray to numpy.ndarray)で落ちます。両制約でスタック全体を NumPy 1.x ABI に揃えていますimport cryspyとcryspyコマンドの起動(Start CrySPY 1.4.3バナー)を確認検証(ISSP ohtaka, Python 3.9 で実施)
インストーラの通しフローを ohtaka で実機実行し end-to-end で成功:
(検証の過程で、Python 3.8 では pyshtools のソースビルドが fftw3 を要求して失敗、numpy を単純に下げると pandas が NumPy2 wheel のままで ABI エラー、という 2 つの落とし穴を特定し、
numpy<2 pandas<2.2の同時固定で解決しました。)補足
cryspy.inが必要です(README に明記)。🤖 Generated with Claude Code