ビルド失敗時の案内改善（ログパス表示・再インストール手順の提示） - #186
Open
k-yoshimi wants to merge 3 commits into
Open
Conversation
- util.sh check(): print the log path on failure when $LOG is set, so users can find $BUILD_DIR/<name>-<ver>-<rev>.log without reading the scripts - All install.sh: follow "Error: $PREFIX exists" with the concrete next step (remove it or bump MA_REVISION in version.sh) Refs #179 (the -h/usage item is deferred to the install.sh consolidation in #184) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
check() printed "See log for details: $LOG" for any non-empty LOG, including one inherited from the user's environment when running download.sh/setup.sh standalone. The hint now requires LOG to point under BUILD_DIR and the file to exist. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Tutorials (review2 en/ja): document the build log location, the 'See log for details' hint, and both recovery options for 'Error: <dir> exists' - Reinstall message now names <NAME>_MA_REVISION, matching the actual variable in version.sh - how_to_use (en): BUILD_DIR was mistranslated as 'Installation directory'; now 'Build working directory' (ja was already correct) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
AI review cycle (Codex + Antigravity) 結果Phase 1 (Codex): must_fix 0 / should_fix 1。
Phase 2 (Antigravity): must_fix_docs 0 → 追加対応:
→ 両フェーズ収束。 マージ順の注意: 本 PR は #178 ( |
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Refs #179（項目 1・2 を実装。項目 3 の
-h/usage は install.sh 共通化 #184 で一括対応するため見送り）1. 失敗時にログパスを表示（util.sh、1 箇所で全アプリに有効）
check()失敗時、$LOGが設定されていればSee log for details: <path>を出力します。53/54 の install.sh がLOGを export 済みなので、ほぼ全ビルド失敗で案内が出ます（export していないのは何もビルドしない gcc-wrapper のみ）。2.
Error: $PREFIX existsに次のアクションを追記（全 54 install.sh）To reinstall, remove it first or increase the MA_REVISION in version.shを直後に追加。機械的 sed による一括挿入で、全ファイルで挿入数が 1 であることを確認済み。検証（macOS で実施)
sh -n通過check falseでFailed:に続きSee log for details:が出ること、LOG未設定時は従来どおりであることを確認MA_ROOTで setup → PREFIX を事前作成 →apps/komega/install.sh実行で、新メッセージ 2 行 + exit 127 を実機確認補足
scripts/util.shのcheck()は #178 も同関数の隣接行を修正しているため、マージ順によっては軽微な競合が出ます（解消は自明）。🤖 Generated with Claude Code