fix_dylib.sh: 引数必須化(引数なし実行時の $HOME 以下 dylib 書き換えを防止) - #174
Open
k-yoshimi wants to merge 1 commit into
Open
Conversation
Without an argument, "cd $1" fell back to $HOME, so the script rewrote install names of every .dylib/.so under the home directory. Now it prints usage and exits, and fails cleanly when the directory does not exist. Fixes #168 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
AI review cycle (Codex + Antigravity) 結果Phase 1 (Codex): must_fix 0 / should_fix 0。optional 1 件(空白入りパスの LIBS ループ分割)は、インストーラ全体が空白パス非対応という契約(#178 で set_prefix に明示ガード追加)のため対象外と判断。 Phase 2 (Antigravity): 指摘ゼロ。リポジトリ内の既存呼び出し元(boost の macos postprocess 等)は引数を渡しており互換性ありと確認。docs からの参照なし。 → 両フェーズ収束。修正コミット不要。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Fixes #168
scripts/fix_dylib.shは引数を省略するとcd $1がcd(引数なし)となって$HOMEへ移動し、ホームディレクトリ配下の全.dylib/.soの install name をinstall_name_toolで書き換えてしまう問題がありました。exit 1cd "$1"の失敗(ディレクトリ不存在)時もexit 1$1/$DIRをクォート検証(macOS で実施)
$HOME以下を走査・書き換えUsage: ... DIRを表示し exit 1$PWD以下を走査(cd 失敗を無視)🤖 Generated with Claude Code