Fix/signal immutability#47
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates autogenerated mock implementations across the SDK to reflect recent interface/type changes (notably around signals) and to standardize mock generation.
Changes:
- Regenerated many
mockery(testify) mocks, addingNew*helpers and nil-safe argument handling inRun()hooks. - Added new mock files for previously-unmocked interfaces (e.g., options market types, prediction/perp extensions).
- Updated
.mockery.yamlto generate mocks undermocks/{{.SrcPackagePath}}with package/struct naming templates and broader package coverage.
Reviewed changes
Copilot reviewed 61 out of 217 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| mocks/github.com/wisp-trading/sdk/pkg/markets/prediction/types/OrderBookWriter.go | Regenerated mock with new mockery header + New* helper and updated type refs |
| mocks/github.com/wisp-trading/sdk/pkg/markets/prediction/types/OrderBookStoreExtension.go | Regenerated mock with updated connector type refs and New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/prediction/types/MarketStoreExtension.go | New generated mock for prediction market store extension |
| mocks/github.com/wisp-trading/sdk/pkg/markets/prediction/types/MarketLoader.go | New generated mock for prediction market loader |
| mocks/github.com/wisp-trading/sdk/pkg/markets/prediction/types/BalanceStoreExtension.go | Regenerated mock with New* helper and nil-safe Run() argument extraction |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/SignalExecutor.go | Regenerated mock; ExecutePerpSignal now uses perp types.PerpSignal |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/PerpWatchlist.go | Regenerated mock; adjusted imports and channel element type reference |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/PerpViews.go | Regenerated mock with New* helper and nil-safe Run() args |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/PerpUniverseProvider.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/PerpSignal.go | Regenerated mock with package/type updates for perp signals |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/PerpRealtimeIngestorFactory.go | Regenerated factory mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/PerpPositionsStoreExtension.go | Regenerated store mock with New* helper and nil-safe Run() args |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/PerpPNL.go | Regenerated PNL mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/PerpBatchIngestorFactory.go | Regenerated factory mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/perp/types/AssetLoader.go | Regenerated loader mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/options/types/SignalExecutor.go | New generated mock for options signal executor |
| mocks/github.com/wisp-trading/sdk/pkg/markets/options/types/OptionsUniverseProvider.go | New generated mock for options universe provider |
| mocks/github.com/wisp-trading/sdk/pkg/markets/options/types/OptionsSignal.go | New generated mock for options signal |
| mocks/github.com/wisp-trading/sdk/pkg/markets/options/types/OptionsRealtimeIngestorFactory.go | New generated mock for options realtime ingestor factory |
| mocks/github.com/wisp-trading/sdk/pkg/markets/options/types/OptionsPNL.go | New generated mock for options PNL |
| mocks/github.com/wisp-trading/sdk/pkg/markets/options/types/OptionsExecutor.go | New generated mock for options executor |
| mocks/github.com/wisp-trading/sdk/pkg/markets/options/types/OptionsBatchIngestorFactory.go | New generated mock for options batch ingestor factory |
| mocks/github.com/wisp-trading/sdk/pkg/markets/options/types/OptionsAssetLoader.go | New generated mock for options asset loader |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/stores/market/StoreExtension.go | Reshuffled generated mock layout; added New* helper earlier in file |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/stores/market/PositionsStoreExtension.go | Regenerated mock with New* helper and nil-safe Run() args |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/stores/market/OrderBookWriter.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/stores/market/OrderBookStoreExtension.go | Regenerated mock with New* helper and nil-safe Run() args |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/stores/market/KlineWriter.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/stores/market/KlineStoreExtension.go | Regenerated mock with New* helper and reordered imports |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/stores/activity/Positions.go | Regenerated mock with New* helper and nil-safe Run() args |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/realtime/WebSocketSubscriber.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/realtime/WebSocketExtension.go | Regenerated mock with New* helper and nil-safe Run() args |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/realtime/RealtimeIngestorFactory.go | Regenerated factory mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/realtime/RealtimeIngestor.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/batch/CollectionExtension.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/batch/BatchIngestorFactory.go | Regenerated factory mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/batch/BatchIngestor.go | Regenerated mock with New* helper and reordered imports |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/PositionCoordinator.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/MarketDataCoordinator.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/ingestors/DataUpdateNotifier.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/MarketWatchlist.go | Regenerated mock with New* helper and nil-safe Run() args |
| mocks/github.com/wisp-trading/sdk/pkg/markets/base/types/AssetLoader.go | Regenerated mock with New* helper |
| mocks/github.com/wisp-trading/sdk/pkg/config/settings/connectors/ValidationService.go | Regenerated mock with New* helper and renamed parameters |
| .mockery.yaml | Expanded/templated mockery config; broadened generation scope |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+11
to
12
| recursive: true | ||
| all: true |
Comment on lines
+9
to
12
| github.com/wisp-trading/sdk/pkg: | ||
| config: | ||
| recursive: true | ||
| all: true |
Comment on lines
+5
to
14
| package types | ||
|
|
||
| import ( | ||
| time "time" | ||
| "time" | ||
|
|
||
| "github.com/google/uuid" | ||
| mock "github.com/stretchr/testify/mock" | ||
| strategy "github.com/wisp-trading/sdk/pkg/types/strategy" | ||
|
|
||
| uuid "github.com/google/uuid" | ||
| "github.com/wisp-trading/sdk/pkg/markets/perp/types" | ||
| "github.com/wisp-trading/sdk/pkg/types/strategy" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.