Re-download group members before syncing when required - #60
Open
StephanBijzitter wants to merge 3 commits into
Open
Re-download group members before syncing when required#60StephanBijzitter wants to merge 3 commits into
StephanBijzitter wants to merge 3 commits into
Conversation
With the intention to use it in SyncButton, where the injector cannot reach
The SyncButton kept its own copy at the time of instantiation, but did not keep the list of to date in the event of changes, leading to a possible mismatch in content
Fixes wise-old-man#59 by re-downloading all group members and waiting for `plugin.groupMembers` to be updated before automatically re-running this function with the up-to-date information. It works, but could use some love.
Contributor
Author
|
While this fixes the issue, it's not ideal as it still relies on downloading a copy of the member list from the website. I estimate a properly efficient fix that does not need to download information would blow up the size of the pull request rather a lot - so I kept this one small and isolated and will follow up with another to improve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59 by re-downloading all group members and waiting for
plugin.groupMembersto be updatedbefore automatically re-running this function with the up-to-date information.
It works, but could use some love.