Competition Team Names Prefix in Chat Messages - #52
Open
codyfarrey wants to merge 17 commits into
Open
Conversation
…PMs, Clan Chats, and Clan Messages (toggalable through config)
…ping special characters
…ion, and added color config
rorro
reviewed
Aug 10, 2024
Comment on lines
+16
to
28
| import java.util.Objects; | ||
| import java.util.Queue; | ||
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import net.runelite.api.ChatLineBuffer; | ||
| import net.runelite.api.MessageNode; | ||
| import net.runelite.api.VarbitComposition; | ||
| import net.runelite.api.WorldType; | ||
| import net.runelite.api.clan.ClanChannel; | ||
| import net.runelite.api.clan.ClanChannelMember; | ||
| import net.runelite.api.events.VarbitChanged; |
Member
There was a problem hiding this comment.
There are a few unused imports here that should be removed.
Comment on lines
+269
to
+286
| @ConfigItem( | ||
| keyName = "displayCompetitionTeamNameTags", | ||
| name = "Display", | ||
| description = "Configures the display of competition team names in clan chat", | ||
| position = 1, | ||
| section = competitionTeamNamesConfig | ||
| ) | ||
| default TeamNameDisplayOptions displayCompetitionTeamNameTags() { return TeamNameDisplayOptions.NONE; } | ||
|
|
||
| @ConfigItem( | ||
| keyName = "teamNameTagColor", | ||
| name = "Name Tag Color", | ||
| description = "Change the color of the Competition Team Name tag in the chat box", | ||
| position = 4, | ||
| section = competitionTeamNamesConfig | ||
| ) | ||
| default Color teamNameTagColor() { return Color.BLACK; } | ||
|
|
Member
There was a problem hiding this comment.
Should we consider putting these under the "Competitions" section instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a change which:
HashMap<String,String>()Evidence below (tested with Csdy2 Test Competition)
Example with Display = None:
Example with Display = Both:
Example with Display = Clan Chats:
Example with Display = Clan Broadcasts:
Example with Display = Both (and Chat TImestamps turned off):
Example with Dispplay = Both (and Chat TImestamps turned off, with other teams chatting):
