fix: lock body scroll and contain mobile sidebar overscroll#12
Open
wintermuted wants to merge 3 commits into
Open
fix: lock body scroll and contain mobile sidebar overscroll#12wintermuted wants to merge 3 commits into
wintermuted wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/wintermuted/ui-theme/sessions/deacfca6-b897-4364-84f5-10c4f1579aae Co-authored-by: wintermuted <2337325+wintermuted@users.noreply.github.com>
Agent-Logs-Url: https://github.com/wintermuted/ui-theme/sessions/deacfca6-b897-4364-84f5-10c4f1579aae Co-authored-by: wintermuted <2337325+wintermuted@users.noreply.github.com>
Agent-Logs-Url: https://github.com/wintermuted/ui-theme/sessions/deacfca6-b897-4364-84f5-10c4f1579aae Co-authored-by: wintermuted <2337325+wintermuted@users.noreply.github.com>
Contributor
|
🚀 PR Preview deployed!
Run |
There was a problem hiding this comment.
Pull request overview
This PR improves the mobile docs experience in the showcase site by preventing background page scrolling while the mobile sidebar drawer is open and by containing touch overscroll within the sidebar.
Changes:
- Added
overscroll-behavior-y: containto the mobile.docs-sidebarto prevent scroll chaining to the page. - Locked background page scrolling on mobile when the sidebar is open via
body.docs-sidebar-open { overflow: hidden; }.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
showcase/showcase.cssWhy
On mobile, sidebar scrolling can be unreliable when background/body scroll remains active. This ensures the drawer scroll behavior is consistent and isolated.