phlib: Implement horizontal scrolling via Shift + Mousewheel - #3012
Open
NotEnsoul wants to merge 1 commit into
Open
phlib: Implement horizontal scrolling via Shift + Mousewheel#3012NotEnsoul wants to merge 1 commit into
NotEnsoul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements horizontal scrolling when holding the
Shiftkey while using the mouse wheel across table, tree, and list controls in the application.TreeNew Control (
phlib/treenew.c):MK_SHIFTflag duringWM_MOUSEWHEELhandling.Shiftis held and horizontal scroll is visible (Context->HScrollVisible), routes mouse wheel turns toPhTnpProcessMouseHWheelwith inverted delta (-Distance), enabling smooth horizontal scrolling.Shiftis not held.Shift+ mousewheel horizontal scrolling across all process, service, network, handle, module, thread, memory, disk, and plugin tables.Extended ListView (
phlib/extlv.c):WM_MOUSEWHEELinPhpExtendedListViewWndProcwhenMK_SHIFTis active.SPI_GETWHEELSCROLLCHARSand dispatchesWM_HSCROLL(SB_LINERIGHT/SB_LINELEFT) messages for horizontal scrolling.Theme Engine (
phlib/theme.c):WM_HSCROLLandWM_MOUSEHWHEELinvalidation support toPhpThemeWindowACLUISubclassProc.Resolves