ci: bump actions to Node 24 versions - #4
Merged
Conversation
actions/checkout@v4 and setup-python@v5 target Node 20, which GitHub is deprecating on its runners. Bump to checkout@v5 and setup-python@v6 (Node 24) to clear the deprecation warning. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wine-fall
added a commit
that referenced
this pull request
Jul 17, 2026
…[spec 04] (#31) The music branch awaited an in-flight-but-not-done prefetched pick, blocking the loop ~56s on a slow long-playlist resolve even with a warm talk beat already buffered (observed live: `music.pick prefetched=True elapsed_s=56.52`). Guard _play_music_segment: when the prefetched pick is still resolving, return to talk and re-attempt music at the next boundary. The pick keeps resolving in the background (slot not cleared, so no duplicate prefetch) and the depth-2 talk look-ahead covers the search adaptively — however long it takes — with no dead air and no hardcoded talk-for-N duration. The cold (nothing-prefetched) and resolved-pick paths are unchanged. Regression test: a fake TrackSource whose pick never resolves yields continuous talk and completes under max_segments (pre-fix the run hung). Aligns spec04 §3.1 Consume + acceptance criterion #4. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the GitHub Actions used in CI off the deprecated Node 20 runtime:
actions/checkout@v4→@v5(ci.yml, pr-conventions.yml)actions/setup-python@v5→@v6(ci.yml)Why
The runners now force
checkout@v4/setup-python@v5(both built for Node 20) onto Node 24 and emit a deprecation warning; when Node 20 support is removed those pins would break. The new majors target Node 24. Behavior is unchanged.Ref: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
AI coding brief
🤖 Generated with Claude Code