Thumbor 5.0 support - #24
Open
aectann wants to merge 4 commits into
Open
Conversation
Methods wrapped with return_future are not supposed to return values. Fixes "@return_future should not be used with functions that return values" problem.
… a config parameter is not defined. Catch and log exceptions on Bucket loader to prevent thumbor from hanging. Do not return callback values directly.
Author
|
@willtrking any chance this will get it? |
|
👍 |
|
I need this! 👍 |
|
This would be very helpful. 👍 |
|
👍 |
|
Hello @aectann ; would you mind submitting your PR to the maintained fork? https://github.com/thumbor-community/aws We'll be happy to review and merge this PR :) |
Author
|
@Bladrak here you go -- thumbor-community#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thumbor 5 release brought breaking changes to their APIs. This PR fixes s3_loader to comply with new APIs.